From owner-cvs-all@FreeBSD.ORG Fri Dec 17 22:10:35 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0AC2116A4CE; Fri, 17 Dec 2004 22:10:35 +0000 (GMT) Received: from connectmail.carleton.ca (connectmail.carleton.ca [134.117.2.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD96F43D5E; Fri, 17 Dec 2004 22:10:34 +0000 (GMT) (envelope-from adamw@magnesium.net) Received: from [192.168.1.105] ([134.117.145.25]) by connectmail.carleton.ca (iPlanet Messaging Server 5.2 HotFix 1.21 (built Sep 8 2003)) with ESMTPSA id <0I8W0051309LEC@connectmail.carleton.ca>; Fri, 17 Dec 2004 17:10:33 -0500 (EST) Date: Fri, 17 Dec 2004 17:12:24 -0500 From: Adam Weinberger In-reply-to: <1103294201.98746.33.camel@pav.hide.vol.cz> To: pav@FreeBSD.org Message-id: <41C359C8.6090708@magnesium.net> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-2; format=flowed Content-transfer-encoding: 8BIT X-Accept-Language: en-us, en User-Agent: Mozilla Thunderbird 1.0 (X11/20041212) References: <200412161851.iBGIpEeq058112@repoman.freebsd.org> <1103275349.98746.10.camel@pav.hide.vol.cz> <20041217141852.GJ79222@elvis.mu.org> <1103294201.98746.33.camel@pav.hide.vol.cz> cc: cvs-ports@FreeBSD.org cc: Alfred Perlstein cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/irc/insub pkg-plist X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2004 22:10:35 -0000 Pav Lucistnik wrote: > Alfred Perlstein píše v pá 17. 12. 2004 v 06:18 -0800: > >>* Pav Lucistnik [041217 01:22] wrote: >> >>>Alfred Perlstein p??e v ?t 16. 12. 2004 v 18:51 +0000: >>> >>>>alfred 2004-12-16 18:51:14 UTC >>>> >>>> FreeBSD ports repository >>>> >>>> Modified files: >>>> irc/insub pkg-plist >>>> Log: >>>> /usr/local/share/cows is usually not empty because a prerequesite of >>>> this port installs file in there. So replace the @dirrm with >>>> "@unexec rmdir %D/share/cows 2>/dev/null || true" as other ports >>>> do. I don't like this, but I don't know what else would work, >>>> it would be nice if this "feature" was implemented as a builtin >>>> to the package system. >>> >>>Is this software supposed to have the original cowsay files (those >>>provided by cowsay port) installed at the runtime? >>> >>>If yes, then you should add cowsay to RUN_DEPENDS and then you could >>>remove handling of share/cows directory from plist completely, because >>>cowsay port (dependency) would handle it. >> >>Yes, but it installs its own cows... >> is that ok? > > > Well, depends. I guess cows from the other package are not doing any > harm? Cowsay needs to be part of the RUN_DEPENDS anyway. Otherwise, you have a bunch of cow files around with nothing that can use them. Besides, cowsay isn't actually part of the build, anyway. Furthermore, the @unexec rm %D/share/cows 2>/dev/null|| true should be added to cowsay's pkg-plist, not insub's. # Adam -- Adam Weinberger adamw@magnesium.net || adamw@FreeBSD.org adamw@vectors.cx || adamw@gnome.org http://www.vectors.cx