From owner-p4-projects@FreeBSD.ORG  Mon Sep  7 19:52:47 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id ECE1F1065676; Mon,  7 Sep 2009 19:52:46 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B17111065670
	for <perforce@freebsd.org>; Mon,  7 Sep 2009 19:52:46 +0000 (UTC)
	(envelope-from andre@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id A0A2F8FC22
	for <perforce@freebsd.org>; Mon,  7 Sep 2009 19:52:46 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n87JqkqT008782
	for <perforce@freebsd.org>; Mon, 7 Sep 2009 19:52:46 GMT
	(envelope-from andre@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n87JqkYL008780
	for perforce@freebsd.org; Mon, 7 Sep 2009 19:52:46 GMT
	(envelope-from andre@freebsd.org)
Date: Mon, 7 Sep 2009 19:52:46 GMT
Message-Id: <200909071952.n87JqkYL008780@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	andre@freebsd.org using -f
From: Andre Oppermann <andre@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 168298 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Sep 2009 19:52:47 -0000

http://perforce.freebsd.org/chv.cgi?CH=168298

Change 168298 by andre@andre_t61 on 2009/09/07 19:52:39

	Require the window to be at least one mss. A smaller window
	is bogus.

Affected files ...

.. //depot/projects/tcp_new/netinet/tcp_syncache.c#6 edit

Differences ...

==== //depot/projects/tcp_new/netinet/tcp_syncache.c#6 (text+ko) ====

@@ -953,6 +953,17 @@
 		goto failed;
 	}
 
+	/*
+	 * Window should be at least one segment.
+	 */
+	if ((th->th_win << sc->sc_requested_r_scale) < sc->sc_peer_mss) {
+		if ((s = tcp_log_addrs(inc, th, NULL, NULL)))
+			log(LOG_DEBUG, "%s; %s: window smaller than one mss, "
+			    "segment rejected\n",
+			    s, __func__);
+		goto failed;
+	}
+
 	*lsop = syncache_socket(sc, *lsop, m);
 
 	if (*lsop == NULL)