From owner-cvs-src@FreeBSD.ORG Tue May 24 11:20:33 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BA6D16A41C for ; Tue, 24 May 2005 11:20:33 +0000 (GMT) (envelope-from Hartmut.Brandt@dlr.de) Received: from smtp-1.dlr.de (smtp-1.dlr.de [195.37.61.185]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F21143D1D for ; Tue, 24 May 2005 11:20:32 +0000 (GMT) (envelope-from Hartmut.Brandt@dlr.de) Received: from beagle.kn.op.dlr.de ([129.247.173.6]) by smtp-1.dlr.de over TLS secured channel with Microsoft SMTPSVC(6.0.3790.211); Tue, 24 May 2005 13:20:31 +0200 Date: Tue, 24 May 2005 13:20:31 +0200 (CEST) From: Harti Brandt X-X-Sender: brandt_h@beagle.kn.op.dlr.de To: Max Okumoto In-Reply-To: Message-ID: <20050524131354.S50725@beagle.kn.op.dlr.de> References: <200505240914.j4O9EkrC043155@repoman.freebsd.org> <4292FE79.70205@ucsd.edu> <20050524124930.F50725@beagle.kn.op.dlr.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 24 May 2005 11:20:31.0583 (UTC) FILETIME=[98B9DEF0:01C56052] Cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.bin/make job.c job.h main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Harti Brandt List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2005 11:20:33 -0000 On Tue, 24 May 2005, Max Okumoto wrote: MO>Harti Brandt writes: MO>[stuff deleted] MO>> MO>Harti, MO>> MO> MO>> MO>Please make sure to attribute patches to DragonFly when you take MO>> MO>things from their CVS. Most of the work is in this patch is yours MO>> MO>but there are some changes that appear like they came from the DragonFly MO>> MO>tree. MO>> MO>> Can you point me at what you think came from DragonFly? If you talk about MO>> the ArgArray stuff, then there is the correct attribution in that commit. MO>> The stuff here was fully done by me. I didn't have a look at DragonFly's MO>> make since I got the ArgArray stuff. MO>> MO>> harti MO> MO>My mistake, if you are not tracking my work any more. MO>It just looked like some minor changes were similar to MO>what I did. Well, as you see from the ArgArray stuff, I'm tracking this when I have time to do so. I was a little bit surprised to see you disappear :-/ I just had a look at the current DFly sources - there's nothing that resembles the work in that commit. NB: It looks like you don't set DEFSHELL anymore in the Makefile, but you still use it in job.c. (I still think that having reviews for something so sensible like make makes sense). This unsetenv("ENV") thing is probably a candidate for a new .SHELL attribute. harti