From owner-freebsd-ports@FreeBSD.ORG Mon May 28 17:32:24 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 913DE106566C for ; Mon, 28 May 2012 17:32:24 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 0F82B8FC08 for ; Mon, 28 May 2012 17:32:23 +0000 (UTC) Received: by bkvi18 with SMTP id i18so3151401bkv.13 for ; Mon, 28 May 2012 10:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=P30uv18Hli+ozJWdFWbGlYa5X+WvgbeEyJNG4i+dHu0=; b=bmsdO1cbKuFZ/AT34gA/KAbXPR/4mdh2r6XLwfXFeZvggOOH2JsdwPKpReAoCyvRzy Dk6Pksxb1NQ94WmOgtJiE1+faWJkuZDj6Tz/yx24M5StuUMOqazR65Dh+rMWMwMwpXp0 3qdbrx49zeKoa/3mMjFZ20Y3MWNgTfI17GG+quTRQFMmo4Jny9VI585X04WpjBXHEgGV wkoofUb8uJmRPAA9Seu+iIMdSX3Znda1Rv6XWZ4Q1IJJg+8rgCxdZDHnbDqC4Pd1Bea2 yQijBrOk87XOO5hwWCSRZYPJLXCMbBekZZ84bgCpbPJxgaXLuo37bwGZzzbemzms9fpD FMvg== Received: by 10.204.154.193 with SMTP id p1mr3920656bkw.102.1338226342966; Mon, 28 May 2012 10:32:22 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.204.171.138 with HTTP; Mon, 28 May 2012 10:31:52 -0700 (PDT) In-Reply-To: <4FC3B1B9.1050703@missouri.edu> References: <20120526090137.001691dc@scorpio> <4FC0F8EA.1090005@missouri.edu> <4FC11B66.9000302@missouri.edu> <4b8eeb05337b220f301268ce014a159d@anthesphoria.net> <4FC2D159.4050801@missouri.edu> <4FC387A9.5070700@missouri.edu> <4FC39E17.1060205@freebsd.org> <4FC3A4FB.1060106@missouri.edu> <4FC3A93C.6080009@t-hosting.hu> <4FC3B1B9.1050703@missouri.edu> From: Chris Rees Date: Mon, 28 May 2012 18:31:52 +0100 X-Google-Sender-Auth: 3m5iCUPEDfp6RLtHC8a3fGKTTR0 Message-ID: To: Stephen Montgomery-Smith Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: =?ISO-8859-1?B?R+Fib3IgS/Z2ZXNk4W4=?= , freebsd-ports@freebsd.org Subject: Re: Request to review: print/texlive-install X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2012 17:32:24 -0000 On 28 May 2012 18:11, Stephen Montgomery-Smith wrote= : > On 05/28/2012 11:35 AM, G=E1bor K=F6vesd=E1n wrote: >> >> On 2012.05.28. 18:16, Stephen Montgomery-Smith wrote: >>>> >>>> >>>> >>>> On 5/28/12 10:11 AM, Stephen Montgomery-Smith wrote: >>>>> >>>>> >>>>> How about if I add lines like this: >>>>> >>>>> .if !defined(IGNORE_SECURITY_RISK) >>>>> IGNORE=3D has a security risk because it downloads a file \ >>>>> without a checksum. Define IGNORE_SECURITY_RISK to build this port >>>>> .endif >>>>> >>>>> Would it be considered OK to commit it then? >>>> >>>> could you host it somewhere that won't go away at missouri.edu? >>>> >>> >>> >>> I could host it somewhere at missouri.edu that will stay as long as I >>> am alive or keep my job. >> >> Better to host it on the FreeBSD mirrors. You only have to create a >> public_distfiles in your home directory after logging in to freefall and >> drop the file there. This is the usual way of doing it. > > > Thank you for the info. =A0Here is my latest version: > > http://people.freebsd.org/~stephen/ > I'm afraid my concerns still hold [1]. This port fetches $WHOKNOWSWHAT from $WHOKNOWSWHERE outside the fetch stage, which isn't how ports are supposed to work. I know 'having a port' is usually considered a good thing, but as I said before, it's no easier or safer to install this via the port than just download and run the script. Also, on deinstall/upgrade the port will clobber anything that was there on install (automatic plist generation also sucks in anything that was there) [2]. Chris [1] http://lists.freebsd.org/pipermail/freebsd-ports/2012-May/075236.html [2] ''' Install texlive-install. Use texlive to grab funky new package. Upgrade texlive-install /* XXX funky new package is now added to texlive-instal plist */ Upgrade texlive-install again Hey, where did $FUNKY go? '''