From owner-cvs-all  Thu Mar 25  1:18:23 1999
Delivered-To: cvs-all@freebsd.org
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.26.10.9])
	by hub.freebsd.org (Postfix) with ESMTP
	id BB43214CF2; Thu, 25 Mar 1999 01:18:18 -0800 (PST)
	(envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id UAA16527;
	Thu, 25 Mar 1999 20:17:57 +1100
Date: Thu, 25 Mar 1999 20:17:57 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199903250917.UAA16527@godzilla.zeta.org.au>
To: luigi@labinfo.iet.unipi.it, mike@smith.net.au
Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c
Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org,
	luigi@FreeBSD.org
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>> >   Modified files:
>> >     sys/netinet          ip_dummynet.c 
>> >   Log:
>> >   add missing #include "opt_bdg.h"
>> 
>> Uh, this should have been "opt_bridge.h", right?
>> 
>> Come on, that's three bytes you've saved.  How about some more 
>> readability?  Please?  8)
>
>good point. i did a better job with "opt_ipdn.h" instead of
>"opt_ip_dummynet.h"...

Not much better.  The options file for DUMMYNET should be named
"opt_dummynet.h".

This is easy to fix.  Poorly chosen option names such as BRIDGE
and XSERVER are hard to fix, because they may be used in countless
users' config files.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message