From owner-freebsd-current@FreeBSD.ORG  Fri Sep 10 18:11:49 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E021416A4CE; Fri, 10 Sep 2004 18:11:49 +0000 (GMT)
Received: from moutng.kundenserver.de (moutng.kundenserver.de
	[212.227.126.173])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8B03443D2F; Fri, 10 Sep 2004 18:11:49 +0000 (GMT)
	(envelope-from se@freebsd.org)
Received: from [212.227.126.179] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1C5psC-0001mO-00; Fri, 10 Sep 2004 20:11:48 +0200
Received: from [80.132.245.176] (helo=Gatekeeper.FreeBSD.org)
	by mrelayng.kundenserver.de with asmtp (Exim 3.35 #1)
	id 1C5psC-0005e8-00; Fri, 10 Sep 2004 20:11:48 +0200
Received: from StefanEsser.FreeBSD.org (StefanEsser [192.168.0.10])
	by Gatekeeper.FreeBSD.org (Postfix) with ESMTP
	id 92D4F5F23; Fri, 10 Sep 2004 20:11:45 +0200 (CEST)
Received: by StefanEsser.FreeBSD.org (Postfix, from userid 200)
	id E7ECF2302; Fri, 10 Sep 2004 20:11:44 +0200 (CEST)
Date: Fri, 10 Sep 2004 20:11:44 +0200
From: Stefan =?iso-8859-1?Q?E=DFer?= <se@FreeBSD.org>
To: Matthew Jacob <mjacob44@yahoo.com>
Message-ID: <20040910181144.GA4513@StefanEsser.FreeBSD.org>
Mail-Followup-To: Stefan =?iso-8859-1?Q?E=DFer?= <se@FreeBSD.org>,
	Matthew Jacob <mjacob44@yahoo.com>,
	Norikatsu Shigemura <nork@FreeBSD.org>, freebsd-current@FreeBSD.org
References: <200409101717.i8AHHGWR044322@sakura.ninth-nine.com>
	<20040910175749.22388.qmail@web21430.mail.yahoo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040910175749.22388.qmail@web21430.mail.yahoo.com>
User-Agent: Mutt/1.5.6i
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:fa3fae9b6ca38d745862a668565919f6
cc: freebsd-current@FreeBSD.org
cc: Norikatsu Shigemura <nork@FreeBSD.org>
Subject: Re: PANIC: sym(4) didn't MODULE_DEPEND cam(4).
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Sep 2004 18:11:50 -0000

On 2004-09-10 10:57 -0700, Matthew Jacob <mjacob44@yahoo.com> wrote:
> 
> Committed- thanks!

How about adding a MODULE_DEPEND on PCI as well, as is common
practice in other PCI device drivers ?

Index: sym_hipd.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/sym/sym_hipd.c,v
retrieving revision 1.49
diff -u -r1.49 sym_hipd.c
--- sym_hipd.c  10 Sep 2004 17:57:33 -0000      1.49
+++ sym_hipd.c  10 Sep 2004 18:08:57 -0000
@@ -8502,6 +8502,7 @@
 
 DRIVER_MODULE(sym, pci, sym_pci_driver, sym_devclass, 0, 0);
 MODULE_DEPEND(sym, cam, 1, 1, 1);
+MODULE_DEPEND(sym, pci, 1, 1, 1);
 
 
 static struct sym_pci_chip sym_pci_dev_table[] = {


Regards, STefan