From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jul 6 19:00:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 9512EA5D for ; Sat, 6 Jul 2013 19:00:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 7CB4F106A for ; Sat, 6 Jul 2013 19:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r66J00ae056974 for ; Sat, 6 Jul 2013 19:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r66J00Ot056973; Sat, 6 Jul 2013 19:00:00 GMT (envelope-from gnats) Resent-Date: Sat, 6 Jul 2013 19:00:00 GMT Resent-Message-Id: <201307061900.r66J00Ot056973@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Kevin Zheng Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 02C2A84D for ; Sat, 6 Jul 2013 18:54:14 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) by mx1.freebsd.org (Postfix) with ESMTP id D02E9103E for ; Sat, 6 Jul 2013 18:54:13 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r66IsDem040374 for ; Sat, 6 Jul 2013 18:54:13 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r66IsDJY040373; Sat, 6 Jul 2013 18:54:13 GMT (envelope-from nobody) Message-Id: <201307061854.r66IsDJY040373@oldred.freebsd.org> Date: Sat, 6 Jul 2013 18:54:13 GMT From: Kevin Zheng To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/180352: [maintainer-update] Trim/cleanup/convert for games/netrek-client-cow X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jul 2013 19:00:00 -0000 >Number: 180352 >Category: ports >Synopsis: [maintainer-update] Trim/cleanup/convert for games/netrek-client-cow >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Sat Jul 06 19:00:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Kevin Zheng >Release: 9.1-RELEASE-p4 >Organization: >Environment: FreeBSD sigma.local 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #0: Mon Jun 17 11:38:17 UTC 2013 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: Do some cleanup work on my port. This entails: - Trim the Makefile header - Remove indefinite article - Switch from USE_GMAKE to USES= gmake - Correctly use ${PREFIX} for sound files - Add patch in preparation for sound support that comes with port I don't plan to bump PORTREVISION just yet; there are no functional changes as sound support doesn't come with the port anyways. >How-To-Repeat: >Fix: Apply the attached patch. Patch attached with submission follows: diff -ruN /usr/ports/games/netrek-client-cow/Makefile ./Makefile --- /usr/ports/games/netrek-client-cow/Makefile 2012-11-16 23:57:46.000000000 -0600 +++ ./Makefile 2013-07-06 13:41:26.000000000 -0500 @@ -1,9 +1,5 @@ -# New ports collection makefile for: netrek-client-cow -# Date created: 20 April 2012 -# Whom: Kevin Zheng -# +# Created by: Kevin Zheng # $FreeBSD: ports/games/netrek-client-cow/Makefile,v 1.4 2012/11/17 05:57:46 svnexp Exp $ -# PORTNAME= netrek-client-cow PORTVERSION= 3.3.1 @@ -13,13 +9,14 @@ http://quozl.us.netrek.org/netrek/ MAINTAINER= kevinz5000@gmail.com -COMMENT= A multi-player battle simulation with a Star Trek theme +COMMENT= Multi-player battle simulation with a Star Trek theme LIB_DEPENDS= Imlib2:${PORTSDIR}/graphics/imlib2 GNU_CONFIGURE= yes -USE_GMAKE= yes +USES= gmake USE_SDL= sdl mixer + CONFIGURE_ARGS+= NORSA='\#' post-patch: @@ -28,7 +25,11 @@ ${REINPLACE_CMD} -e 's|inline void|void|' \ ${WRKSRC}/local.[ch] ${REINPLACE_CMD} -e 's|/usr|${PREFIX}|' \ - ${WRKSRC}/x11sprite.c ${WRKSRC}/netrek-client-cow.desktop + ${WRKSRC}/netrek-client-cow.desktop \ + ${WRKSRC}/sound.c \ + ${WRKSRC}/x11sprite.c + ${REINPLACE_CMD} -e 's|8000, AUDIO_U8, 1|22050, AUDIO_U8, 2|' \ + ${WRKSRC}/sound.c ${REINPLACE_CMD} -e 's|games|bin|' \ ${WRKSRC}/netrek-client-cow.desktop >Release-Note: >Audit-Trail: >Unformatted: