From owner-cvs-all  Thu Mar 25  1:38:17 1999
Delivered-To: cvs-all@freebsd.org
Received: from labinfo.iet.unipi.it (labinfo.iet.unipi.it [131.114.9.5])
	by hub.freebsd.org (Postfix) with SMTP
	id 0388F14E28; Thu, 25 Mar 1999 01:38:12 -0800 (PST)
	(envelope-from luigi@labinfo.iet.unipi.it)
Received: from localhost (luigi@localhost) by labinfo.iet.unipi.it (8.6.5/8.6.5) id IAA12325; Thu, 25 Mar 1999 08:23:27 +0100
From: Luigi Rizzo <luigi@labinfo.iet.unipi.it>
Message-Id: <199903250723.IAA12325@labinfo.iet.unipi.it>
Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c
To: bde@zeta.org.au (Bruce Evans)
Date: Thu, 25 Mar 1999 08:23:27 +0100 (MET)
Cc: mike@smith.net.au, cvs-all@FreeBSD.org,
	cvs-committers@FreeBSD.org, luigi@FreeBSD.org
In-Reply-To: <199903250917.UAA16527@godzilla.zeta.org.au> from "Bruce Evans" at Mar 25, 99 08:17:38 pm
X-Mailer: ELM [version 2.4 PL23]
Content-Type: text
Content-Length: 1503      
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

> >> Come on, that's three bytes you've saved.  How about some more 
> >> readability?  Please?  8)
> >
> >good point. i did a better job with "opt_ipdn.h" instead of
> >"opt_ip_dummynet.h"...
> 
> Not much better.  The options file for DUMMYNET should be named
> "opt_dummynet.h".

just in saving chars i meant...

> This is easy to fix.  Poorly chosen option names such as BRIDGE
> and XSERVER are hard to fix, because they may be used in countless
> users' config files.

since you opened the discussion on option names: do you have a better
name for BRIDGE ? something like NET_BRIDGE or so ?

There is another thing: having to explicitly include "opt_foo.h" in all
files related to "foo" opens the door to subtle bugs that might not be
detected at compile time or might even cause inconsistent behaviour at
run time.

I understand that name space pollution issues do not leave the option
of having all "opt_*" included in "opt_global.h" unless we standardize names
in a way that reduces conflicts... So should we go for that, e.g. having

	OPT_*	for generic options
	DEV_*	for devices

and so on ?

	thanks
	luigi
-----------------------------------+-------------------------------------
  Luigi RIZZO                      .
  EMAIL: luigi@iet.unipi.it        . Dip. di Ing. dell'Informazione
  HTTP://www.iet.unipi.it/~luigi/  . Universita` di Pisa
  TEL/FAX: +39-050-568.533/522     . via Diotisalvi 2, 56126 PISA (Italy)
-----------------------------------+-------------------------------------


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message