From owner-cvs-src@FreeBSD.ORG Tue May 24 12:01:14 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B1E016A41C; Tue, 24 May 2005 12:01:14 +0000 (GMT) (envelope-from okumoto@ucsd.edu) Received: from postal.sdsc.edu (postal.sdsc.edu [132.249.20.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id B2B9443D4C; Tue, 24 May 2005 12:01:13 +0000 (GMT) (envelope-from okumoto@ucsd.edu) Received: from multivac.sdsc.edu (IDENT:Nt3BHT0yBK2BpKhRPoW1Ef9J85xbB1VS@multivac.sdsc.edu [132.249.20.57]) by postal.sdsc.edu (8.11.7/8.11.7/server/70) with ESMTP id j4OC1DP17700; Tue, 24 May 2005 05:01:13 -0700 (PDT) Received: (from okumoto@localhost) by multivac.sdsc.edu (8.12.10+Sun/8.12.10/submit/s/4) id j4OC1DJb007929; Tue, 24 May 2005 05:01:13 -0700 (PDT) X-Authentication-Warning: multivac.sdsc.edu: okumoto set sender to okumoto@ucsd.edu using -f To: Harti Brandt References: <200505240914.j4O9EkrC043155@repoman.freebsd.org> <4292FE79.70205@ucsd.edu> <20050524124930.F50725@beagle.kn.op.dlr.de> <20050524131354.S50725@beagle.kn.op.dlr.de> From: Max Okumoto Date: Tue, 24 May 2005 05:01:12 -0700 In-Reply-To: <20050524131354.S50725@beagle.kn.op.dlr.de> (Harti Brandt's message of "Tue, 24 May 2005 13:20:31 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.2 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.bin/make job.c job.h main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2005 12:01:14 -0000 Harti Brandt writes: > On Tue, 24 May 2005, Max Okumoto wrote: > > MO>Harti Brandt writes: > MO>[stuff deleted] > MO>> MO>Harti, > MO>> MO> > MO>> MO>Please make sure to attribute patches to DragonFly when you take > MO>> MO>things from their CVS. Most of the work is in this patch is yours > MO>> MO>but there are some changes that appear like they came from the DragonFly > MO>> MO>tree. > MO>> > MO>> Can you point me at what you think came from DragonFly? If you talk about > MO>> the ArgArray stuff, then there is the correct attribution in that commit. > MO>> The stuff here was fully done by me. I didn't have a look at DragonFly's > MO>> make since I got the ArgArray stuff. > MO>> > MO>> harti > MO> > MO>My mistake, if you are not tracking my work any more. > MO>It just looked like some minor changes were similar to > MO>what I did. > > Well, as you see from the ArgArray stuff, I'm tracking this when I have > time to do so. I was a little bit surprised to see you disappear :-/ Well, I got the impression that didn't want stuff from me. After I asked you to revert a change that broke a 20+ patches that I had pending to send to you. You ignored the request. And your response was to point out that one of the earlier patches had a mistake. After that, the commits you did later on had gratuious white space changes, and a double semi colon. Shrug. > > I just had a look at the current DFly sources - there's nothing that > resembles the work in that commit. > > NB: It looks like you don't set DEFSHELL anymore in the Makefile, but you > still use it in job.c. (I still think that having reviews for something so > sensible like make makes sense). This unsetenv("ENV") thing is probably a > candidate for a new .SHELL attribute. > > harti Thanks I will fix that. Max