From owner-freebsd-scsi@FreeBSD.ORG  Wed Dec  2 16:08:52 2009
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: scsi@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7366410656C0;
	Wed,  2 Dec 2009 16:08:52 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.freebsd.org (Postfix) with ESMTP id 26A498FC1A;
	Wed,  2 Dec 2009 16:08:51 +0000 (UTC)
Received: from [IPv6:::1] (pooker.samsco.org [168.103.85.57])
	(authenticated bits=0)
	by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id nB2G8mpJ074474;
	Wed, 2 Dec 2009 09:08:49 -0700 (MST)
	(envelope-from scottl@samsco.org)
Mime-Version: 1.0 (Apple Message framework v1076)
Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes
From: Scott Long <scottl@samsco.org>
In-Reply-To: <20091202135919.GA3675@a91-153-117-195.elisa-laajakaista.fi>
Date: Wed, 2 Dec 2009 09:08:48 -0700
Content-Transfer-Encoding: 7bit
Message-Id: <060A52A1-CFD0-4866-AD23-A1B47A2E79B5@samsco.org>
References: <20091201180524.GB7961@a91-153-117-195.elisa-laajakaista.fi>
	<20091201142930.I99667@pooker.samsco.org>
	<20091202135919.GA3675@a91-153-117-195.elisa-laajakaista.fi>
To: Jaakko Heinonen <jh@FreeBSD.org>
X-Mailer: Apple Mail (2.1076)
X-Spam-Status: No, score=-4.4 required=3.8 tests=ALL_TRUSTED,BAYES_00
	autolearn=ham version=3.1.8
X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org
Cc: scsi@FreeBSD.org
Subject: Re: cd(4) M_WAITOK allocations with periph lock held
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Dec 2009 16:08:52 -0000

Done, thanks!

Scott

On Dec 2, 2009, at 6:59 AM, Jaakko Heinonen wrote:

>
> Hi,
>
> On 2009-12-01, Scott Long wrote:
>> How about the attached match instead.  It refactors the code so that
>> unlocks aren't needed.
>
> Looks OK to me. Some nits below.
>
>> bailout:
>> +	xpt_release_ccb(ccb);
>> +	cam_periph_unlock(periph);
>> +
>
> The file seems to have an empty line after labels in other places.  
> Maybe
> put one here too.
>
>> bailout:
>>
>> +	xpt_release_ccb(ccb);
>> +	cam_periph_unlock(periph);
>
> You can remove the now unused "bailout:" label from cdsendkey().
>
> Do you want to commit it?
>
> Thanks.
> -- 
> Jaakko