From owner-cvs-src@FreeBSD.ORG Wed Apr 30 17:49:20 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7DFF4106564A; Wed, 30 Apr 2008 17:49:20 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 2A1A58FC0A; Wed, 30 Apr 2008 17:49:20 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m3UHnJ7Y057836 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 30 Apr 2008 10:49:19 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <4818B11F.6050609@freebsd.org> Date: Wed, 30 Apr 2008 10:49:19 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.9 (X11/20071125) MIME-Version: 1.0 To: obrien@freebsd.org References: <200804292135.m3TLZONF045026@repoman.freebsd.org> <20080430165352.GA89079@dragon.NUXI.org> <4818A559.1010903@freebsd.org> <20080430174023.GA22190@dragon.NUXI.org> In-Reply-To: <20080430174023.GA22190@dragon.NUXI.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-dcc1-Metrics: ebb.errno.com; whitelist Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: CVSROOT exclude X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Apr 2008 17:49:20 -0000 David O'Brien wrote: > On Wed, Apr 30, 2008 at 09:59:05AM -0700, Sam Leffler wrote: > >> David O'Brien wrote: >> >>> On Tue, Apr 29, 2008 at 09:35:24PM +0000, Sam Leffler wrote: >>> >>>> . exclude Log: >>>> add iwn firmware >>>> >>> Hi Sam, >>> I notice we keep excluding $FreeBSD$ from uuencoded firmware files. >>> At least looking at sys/contrib/dev/iwn/iwlwifi-4965-4.44.17.fw.uu, >>> which has a Copyright notice at the top, I think the use of this file >>> would tolerate a $FreeBSD$ on the first line. >>> >>> Would you mind if I fixed this? >>> >>> >> I copied previous practice in excluding the entire directory. >> > > I think "the previous practice" mostly comes from the wireless firmware > where the folks committing it may not have realized that "$FreeBSD$" will > be nicely ignored by uudecode. > I was involved with placing the other Intel firmware in sys/contrib. > >> The issue >> isn't whether it's possible to insert a keyword but rather whether it's a >> good idea to alter files (like the LICENSE files) that come directly from >> "the vendor" under limited terms. >> > > # $FreeBSD: src/sys/contrib/dev/ral/rt2860.fw.uu,v 1.1 2008/04/20 20:35:35 sam Exp $ > (and the other *.uu's there) are examples where we've done it. And I > think its fine. > > Note, if these come straight from a vendor, why aren't they being vendor > imported? > > If "these" refers to the ralink firmware images they do not come straight from the vendor; I generated them from the rt2661_ucode.h file I got from obsd CVS. The LICENSE file in that directory however could/should be intact but I was lazy; I will correct that. I'm not opposed to adding a keyword but I don't want to have to go back through lawyers to get approval. If you want to do all the work be my guest. Sam