From owner-freebsd-net@FreeBSD.ORG  Wed Aug 21 14:11:20 2013
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id A1972DF7;
 Wed, 21 Aug 2013 14:11:20 +0000 (UTC)
 (envelope-from julian@freebsd.org)
Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 595022E75;
 Wed, 21 Aug 2013 14:11:19 +0000 (UTC)
Received: from jre-mbp.elischer.org (etroy.elischer.org [121.45.226.51])
 (authenticated bits=0)
 by vps1.elischer.org (8.14.7/8.14.6) with ESMTP id r7LEBEvF009606
 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Wed, 21 Aug 2013 07:11:17 -0700 (PDT)
 (envelope-from julian@freebsd.org)
Message-ID: <5214CA7E.2040604@freebsd.org>
Date: Wed, 21 Aug 2013 22:11:10 +0800
From: Julian Elischer <julian@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8;
 rv:17.0) Gecko/20130801 Thunderbird/17.0.8
MIME-Version: 1.0
To: Andre Oppermann <andre@freebsd.org>
Subject: Re: Further mbuf adjustments and changes
References: <5214C365.6020802@freebsd.org>
In-Reply-To: <5214C365.6020802@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: freebsd-net@freebsd.org, freebsd-current@freebsd.org
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Aug 2013 14:11:20 -0000

On 8/21/13 9:40 PM, Andre Oppermann wrote:
> [ actual text removed.. ]

> Patch is available here:
>
>  http://people.freebsd.org/~andre/mbuf-adjustments-20130821.diff

one small thing I noticed..

-		u16 type = (CSUM_DATA_VALID | CSUM_PSEUDO_HDR);
+		u64 type = (CSUM_DATA_VALID | CSUM_PSEUDO_HDR);
  #if __FreeBSD_version >= 800000


if we are (in ixgbe) supporting different versions then your chang 
eneeds to be enclosed in a
    #if __FreeBSD_version >= 100000000
section

does anyone have a copy of jeff's old mbuf rewrite from a couple of 
years ago?
Have you looked at it? is there overlap?

I'm not sure that we have much of a gain any more by having mbufs with 
built in storage, except to complicate the code.   we could just have 
small external storage types so tha tthe mbuf itself was always 
'external'..