From owner-freebsd-net Fri Nov 16 16:16:29 2001 Delivered-To: freebsd-net@freebsd.org Received: from elvis.mu.org (elvis.mu.org [216.33.66.196]) by hub.freebsd.org (Postfix) with ESMTP id 8325E37B418; Fri, 16 Nov 2001 16:16:23 -0800 (PST) Received: by elvis.mu.org (Postfix, from userid 1192) id 3EE9981D01; Fri, 16 Nov 2001 18:16:18 -0600 (CST) Date: Fri, 16 Nov 2001 18:16:18 -0600 From: Alfred Perlstein To: Peter Wemm Cc: Julian Elischer , current@FreeBSD.ORG, net@FreeBSD.ORG, wollman@FreeBSD.ORG Subject: Re: re-entrancy and the IP stack. Message-ID: <20011116181618.A13393@elvis.mu.org> References: <3BF5A5D5.3D408744@vicor-nb.com> <20011117000251.A13B93811@overcee.netplex.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011117000251.A13B93811@overcee.netplex.com.au>; from peter@wemm.org on Fri, Nov 16, 2001 at 04:02:51PM -0800 Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org * Peter Wemm [011116 18:02] wrote: > Julian Elischer wrote: > [..] > > What is needed is obviously a 'per packet' storage location > > for those things, defined in a "per protocol family" manner. > > > > Luigi has already tried this scheme by defining a > > dummynet specific mbuf type that can be prepended to the > > front of packets. What I suggest is to extend this > > to defining a MT_PROTOSTORAGE. (or similar) mbuf type > > that generic networking code is educated to ignore, > > and that protocols can use to pass packet-specific state > > information from one place to another. > > Uhh.. no thanks. Whatever you do, do *NOT* abuse the mbuf system > for this. We went to a lot of trouble (well, Garrett specifically) > to rid the stacks of this obscenity. Do *NOT* generalize it and undo > it. MT_DUMMYNET must die, not be propagated elsewhere. > > If you want to have some general storage mechnaism, do *not* use mbufs > for it. *cough* kthread_setspecific() *cough* kthread_getspecific() *cough* or just fix the code to pass this around as an extra paramter. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' http://www.morons.org/rants/gpl-harmful.php3 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message