From owner-cvs-all  Fri Feb  7 22:34:10 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D973B37B407; Fri,  7 Feb 2003 22:34:06 -0800 (PST)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8524C43FA3; Fri,  7 Feb 2003 22:34:06 -0800 (PST)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 45F21AE27F; Fri,  7 Feb 2003 22:34:06 -0800 (PST)
Date: Fri, 7 Feb 2003 22:34:06 -0800
From: Alfred Perlstein <bright@mu.org>
To: David O'Brien <obrien@FreeBSD.org>
Cc: Chad David <davidc@FreeBSD.org>, src-committers@FreeBSD.org,
	cvs-src@FreeBSD.org, cvs-all@FreeBSD.org,
	legacy-committers@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/yacc skeleton.c
Message-ID: <20030208063406.GG88781@elvis.mu.org>
References: <200302070339.h173dRvU071460@repoman.freebsd.org> <20030208062131.GA7362@dragon.nuxi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030208062131.GA7362@dragon.nuxi.com>
User-Agent: Mutt/1.4i
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

* David O'Brien <obrien@FreeBSD.org> [030207 22:23] wrote:
> On Thu, Feb 06, 2003 at 07:39:27PM -0800, Chad David wrote:
> > davidc      2003/02/06 19:39:27 PST
> > 
> >   Modified files:
> >     usr.bin/yacc         skeleton.c 
> >   Log:
> >   Add __unused to the declaration of yyrcsid.
> >   
> >   Revision  Changes    Path
> >   1.35      +2 -1      src/usr.bin/yacc/skeleton.c
> > http://cvsweb.freebsd.org/src/usr.bin/yacc/skeleton.c.diff?r1=1.34&r2=1.35
> 
> Please back this out.  Non-portable parsers are now produced.  Not every
> OS has <sys/cdefs.h>, nor do they understand "__unused".

How about taking the time to offer advice that will gain us forward
progress?  Chad wants to get rid of warnings from the code produced,
perhaps if he added #ifdef __FreeBSD__ or something to the generated
output?

-- 
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
 start asking why software is ignoring 30 years of accumulated wisdom.'

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message