From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Sep 6 03:40:06 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C916810656D1 for ; Mon, 6 Sep 2010 03:40:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A7A708FC21 for ; Mon, 6 Sep 2010 03:40:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o863e6Zk008503 for ; Mon, 6 Sep 2010 03:40:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o863e6u0008502; Mon, 6 Sep 2010 03:40:06 GMT (envelope-from gnats) Date: Mon, 6 Sep 2010 03:40:06 GMT Message-Id: <201009060340.o863e6u0008502@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Michael Smith Cc: Subject: Re: ports/150235: sysutils/smartmontools build system bug X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Michael Smith List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Sep 2010 03:40:06 -0000 The following reply was made to PR ports/150235; it has been noted by GNATS. From: Michael Smith To: Alex Samorukov Cc: Doug Barton , Garrett Wollman , bug-followup@FreeBSD.org Subject: Re: ports/150235: sysutils/smartmontools build system bug Date: Sun, 5 Sep 2010 20:20:45 -0700 --Apple-Mail-6-493367618 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Alex, I haven't maintained the ciss driver in a long time. I'm sure what = you're asking for is reasonable, but you'd need to find out who's = currently looking after it... =3D Mike On Sep 5, 2010, at 3:39 PM, Alex Samorukov wrote: > Hi Michael, >=20 > I am one of the smartmontools developers and smartmontools port = maintainer. Smartmontools project implements ciss device support on a = FreeBSD to obtain smart information from the drives attached to the ciss = controller. To interact with a ciss devices we are using defines from = the cissio.h header. Unfortunately this file is not included in the = /usr/include/sys, and this makes ciss support in smartctl dependable on = installed kernel sources. This makes a problems for some user (see = http://www.freebsd.org/cgi/query-pr.cgi?pr=3D150235). Is it possible to = install this (and probably other headers) file to the /usr/include/sys = on a make install process? This will allow to build fully functional = smartmontools without kernel sources installed. >=20 >=20 > On 09/06/2010 12:22 AM, Philip Paeps wrote: >> On 2010-09-06 00:06:54 (+0200), Alex Samorukov = wrote: >> =20 >>> On 09/05/2010 11:44 PM, Doug Barton wrote: >>> =20 >>>> On 09/05/2010 12:28 PM, Alex Samorukov wrote: >>>> =20 >>>>> Your proposed patch will break smartmontools functionality - thats = why >>>>> i`m not able to accept it. >>>>> =20 >>>> It's not at all clear to me why developers@ is cc'ed on these >>>> messages, but since we are ... >>>>=20 >>>> Alex, >>>>=20 >>>> Can you please explain why the change Garrett is suggesting will = break >>>> anything? According to his PR all the headers that smartmontools = needs >>>> are included in /usr/include. Is that not the case? >>>> =20 >>> It is not the case. cciss.cpp from the sources uses = dev/ciss/cissio.h to >>> work with cciss devices on FreeBSD. configure script checks if this = file >>> is exists on the compile time, and if its not - does not compile = cciss >>> support in the smartmontools. >>> If user will try to use cciss driver in this case - smartmontools = will >>> display an error: >>>=20 >>> "CCISS support is not available in this build of smartmontools,\n" >>> "/usr/src/sys/dev/ciss/cissio.h was not available at build = time.\n\n"); >>> =20 >> If that interface is public (which it seems to be, from glancing at = the file), >> the header should be installed in /usr/include/sys. There are = precedents for >> this, see and (and presumably = others). >>=20 >> Any reason not to follow Garrett's suggestion to work with a src = developer, >> perhaps one of the ones listed in the header file you need, to have = it put >> somewhere public? >>=20 >> - Philip >>=20 >> =20 >=20 -- True terror is to wake up one morning and discover that your high school = class is running the country. -- Kurt Vonnegut --Apple-Mail-6-493367618 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
Hi Michael,

I am one of the smartmontools = developers and  smartmontools port maintainer.  Smartmontools = project implements ciss device support on a FreeBSD to obtain smart = information from the drives attached to the ciss controller. To interact = with a ciss devices we are using defines from the cissio.h header. = Unfortunately this file is not included in the /usr/include/sys, and = this makes ciss support in smartctl dependable on installed kernel = sources. This makes a problems for some user (see http://www.fr= eebsd.org/cgi/query-pr.cgi?pr=3D150235). Is it possible to install = this (and probably other headers) file to the /usr/include/sys on a make = install process? This will allow to build fully functional smartmontools = without kernel sources installed.


On 09/06/2010 12:22 AM, = Philip Paeps wrote:
On 2010-09-06 00:06:54 = (+0200), Alex Samorukov<samm@os2.kiev.ua> =  wrote:
=   
On 09/05/2010 11:44 PM, Doug Barton = wrote:
=     
On = 09/05/2010 12:28 PM, Alex Samorukov = wrote:
=       
Your proposed patch will break = smartmontools functionality - thats = why
i`m not able to accept = it.
=         
It's not at all clear to me why = developers@ is cc'ed on = these
messages, but since we are = ...

Alex,

Can = you please explain why the change Garrett is suggesting will = break
anything? According to his PR all the headers that = smartmontools = needs
are = included in /usr/include. Is that not the = case?
=       
It is not the = case. cciss.cpp from the sources uses dev/ciss/cissio.h = to
work with cciss devices on FreeBSD. configure script = checks if this file
is exists on the compile time, = and if its not - does not compile = cciss
support in the = smartmontools.
If user will try to use cciss = driver in this case - smartmontools = will
display an error:

"CCISS support is not available = in this build of = smartmontools,\n"
"/usr/src/sys/dev/ciss/cissio.h = was not available at build = time.\n\n");
=     
If that interface is public (which it seems to be, from = glancing at the file),
the = header should be installed in /usr/include/sys.  There are = precedents for
this, = see<sys/aac_ioctl.h>  and<sys/digiio.h>  (and = presumably others).

Any reason not = to follow Garrett's suggestion to work with a src = developer,
perhaps one of the = ones listed in the header file you need, to have it = put
somewhere = public?

 - = Philip

=   


 Kurt = Vonnegut







= --Apple-Mail-6-493367618--