From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Feb 9 21:20:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B3487F34 for ; Sat, 9 Feb 2013 21:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id A29C08C2 for ; Sat, 9 Feb 2013 21:20:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r19LK12B045622 for ; Sat, 9 Feb 2013 21:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r19LK1x6045618; Sat, 9 Feb 2013 21:20:01 GMT (envelope-from gnats) Date: Sat, 9 Feb 2013 21:20:01 GMT Message-Id: <201302092120.r19LK1x6045618@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: Martin Tournoij Subject: Re: ports/175976: [patch] Install desktop icon for games/boswars X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Martin Tournoij List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Feb 2013 21:20:01 -0000 The following reply was made to PR ports/175976; it has been noted by GNATS. From: Martin Tournoij To: bug-followup@FreeBSD.org Cc: Subject: Re: ports/175976: [patch] Install desktop icon for games/boswars Date: Sat, 9 Feb 2013 22:17:53 +0100 On Sat, Feb 09, 2013 at 04:20:07AM +0000, Edwin Groothuis wrote: > Maintainer of games/boswars, > > Please note that PR ports/175976 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/175976 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org Thank you Kevin. I don't use a desktop environment, so I never noticed the broken icon :-/ As for the portlint error, I don't see any (?) [/home/martin/boswars]# portlint -A WARN: Makefile: [30]: possible direct use of command "false" found. use ${FALSE} instead. WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. WARN: Makefile: new ports should not set PORTREVISION. WARN: Makefile: only one MASTER_SITE configured. Consider adding additional mirrors. 0 fatal errors and 4 warnings found. [/home/martin/boswars]# portlint -V portlint version 2.13.13 In any case, this patch looks OK. -- Martin Tournoij http://arp242.net | http://daemonforums.org QOTD: HELP! MY TYPEWRITER IS BROKEN! -- E. E. CUMMINGS