From owner-cvs-src@FreeBSD.ORG Mon Apr 2 01:04:21 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C3E2916A401; Mon, 2 Apr 2007 01:04:21 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id B4E6C13C43E; Mon, 2 Apr 2007 01:04:21 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3214LOk075435; Mon, 2 Apr 2007 01:04:21 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3214LtV075434; Mon, 2 Apr 2007 01:04:21 GMT (envelope-from mjacob) Message-Id: <200704020104.l3214LtV075434@repoman.freebsd.org> From: Matt Jacob Date: Mon, 2 Apr 2007 01:04:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf NOTES src/sys/dev/isp isp_freebsd.c isp_freebsd.h isp_library.c isp_library.h isp_pci.c isp_sbus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2007 01:04:21 -0000 mjacob 2007-04-02 01:04:21 UTC FreeBSD src repository Modified files: sys/conf NOTES sys/dev/isp isp_freebsd.c isp_freebsd.h isp_library.c isp_library.h isp_pci.c isp_sbus.c Log: Temporarily desupport simultaneous target and initiator mode. When the linux port changes were imported which split the target command list to be separate from the initiator command list and the handle format changed to encode a type in the handle the implications to the function isp_handle_index (which only the NetBSD/OpenBSD/FreeBSD ports use) were overlooked. The fault is twofold: first, the index into the DMA maps in isp_pci is wrong because a target command handle with the type bit left in place caused a bad index (and panic) into dma map. Secondly, the assumption of the array of DMA maps in either PCS or SBUS attachment structures is that there is a linear mapping between handle index and DMA map index. This can no longer be true if there are overlapping index spaces for initiator mode and target mode commands. These changes bandaid around the problem by forcing us to not have simultaneous dual roles and doing the appropriate masking to make sure things are indexed correctly. A longer term fix is being devloped. Revision Changes Path 1.1418 +6 -2 src/sys/conf/NOTES 1.137 +9 -1 src/sys/dev/isp/isp_freebsd.c 1.104 +7 -1 src/sys/dev/isp/isp_freebsd.h 1.13 +7 -7 src/sys/dev/isp/isp_library.c 1.8 +2 -0 src/sys/dev/isp/isp_library.h 1.142 +8 -6 src/sys/dev/isp/isp_pci.c 1.32 +5 -3 src/sys/dev/isp/isp_sbus.c