From owner-freebsd-bugs@FreeBSD.ORG Mon Dec 22 05:00:42 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7304D16A4CE for ; Mon, 22 Dec 2003 05:00:42 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id F283843D5D for ; Mon, 22 Dec 2003 05:00:35 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) hBMD0ZFR083660 for ; Mon, 22 Dec 2003 05:00:35 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id hBMD0ZYG083655; Mon, 22 Dec 2003 05:00:35 -0800 (PST) (envelope-from gnats) Resent-Date: Mon, 22 Dec 2003 05:00:35 -0800 (PST) Resent-Message-Id: <200312221300.hBMD0ZYG083655@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Gleb Smirnoff Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1182916A4CE for ; Mon, 22 Dec 2003 04:55:14 -0800 (PST) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B6DE43D5D for ; Mon, 22 Dec 2003 04:55:12 -0800 (PST) (envelope-from glebius@cell.sick.ru) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.9/8.12.8) with ESMTP id hBMCt9AB087994 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 22 Dec 2003 15:55:09 +0300 (MSK) (envelope-from glebius@cell.sick.ru) Received: (from glebius@localhost) by cell.sick.ru (8.12.9/8.12.6/Submit) id hBMCt8rU087993; Mon, 22 Dec 2003 15:55:08 +0300 (MSK) Message-Id: <200312221255.hBMCt8rU087993@cell.sick.ru> Date: Mon, 22 Dec 2003 15:55:08 +0300 (MSK) From: Gleb Smirnoff To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/60503: small error in modules installation X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Dec 2003 13:00:42 -0000 >Number: 60503 >Category: kern >Synopsis: small error in modules installation >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Dec 22 05:00:35 PST 2003 >Closed-Date: >Last-Modified: >Originator: Gleb Smirnoff >Release: FreeBSD 4.9-PRERELEASE i386 >Organization: Bestcom ISP >Environment: System: FreeBSD cell.sick.ru 4.9-PRERELEASE FreeBSD 4.9-PRERELEASE #0: Fri Sep 19 10:22:46 MSD 2003 root@fade.bestcom.ru:/usr/obj/usr/src/sys/NUCLEUS i386 >Description: When ${KMODDIR}, usually /modules, does not exist modules installation process does not fail, but all modules are written into file /modules, overwriting each other. >How-To-Repeat: su-2.05b# rm -rf /modules su-2.05b# cd /usr/src/sys/modules/if_gif su-2.05b# make ... su-2.05b# make install install -o root -g wheel -m 555 if_gif.ko /modules su-2.05b# file /modules /modules: ELF 32-bit LSB shared object, Intel 80386, version 1 (FreeBSD), not stripped make installkernel will write all modules into one file "/modules". >Fix: --- kmod.mk.orig Mon Dec 22 15:29:59 2003 +++ kmod.mk Mon Dec 22 15:43:49 2003 @@ -183,6 +183,9 @@ realinstall: _kmodinstall .ORDER: beforeinstall _kmodinstall _kmodinstall: +.if !exists(${KMODDIR}) + @mkdir -p ${KMODDIR}; +.endif ${INSTALL} -o ${KMODOWN} -g ${KMODGRP} -m ${KMODMODE} \ ${_INSTALLFLAGS} ${PROG} ${DESTDIR}${KMODDIR} .endif !target(realinstall) >Release-Note: >Audit-Trail: >Unformatted: