From owner-svn-src-all@FreeBSD.ORG Thu Jan 22 01:05:00 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B8895477 for ; Thu, 22 Jan 2015 01:05:00 +0000 (UTC) Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C58EB72 for ; Thu, 22 Jan 2015 01:05:00 +0000 (UTC) Received: by mail-pa0-f45.google.com with SMTP id lf10so56498976pab.4 for ; Wed, 21 Jan 2015 17:04:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=hwPEmUo/aCZCuNxemfa4vVsAHwT3NpS1ZR44jRXBNm4=; b=Wkqa+NuIrUyj/xAcYqrKgivF80J004Lezo/p0/RXaF0KLrdrr28PoH36kn1ZMeAn2w dcsSQbv3b7e+LxVUhpLK8CPrsuEe9KXrXCjNABMSHN5Z98hHSr04z5JpMlEenI2wUtaP JwDcs9cW0P0Uig9SQ0s9MRkvLx4V0Gsj/St0ZFzxGk+3Ipc92pVIVmbnf8HdUFiQ/Ut9 hqKSSSgfzJDsg4ej6/WKvypKbRC05h7K63O/yF1VUbO/wokqiNhiVMEXRIF92KSYcorC j604bb+dxbsgQDJsU6fudiVeNQQO9FPCZdqBCcyedOQyLuhE7ingavyg7u6l//KqAcHO w9pQ== X-Gm-Message-State: ALoCoQm4jZ4GT11vJwgqBkCYwB5wnYXHZL4xxChGovO8AHZ7zIPDYoXi7cnpduUJWnwPYXJvGQjd X-Received: by 10.66.163.228 with SMTP id yl4mr41048675pab.51.1421888699651; Wed, 21 Jan 2015 17:04:59 -0800 (PST) Received: from bsdimp.corp.netflix.com ([69.53.237.72]) by mx.google.com with ESMTPSA id kg12sm7086883pbb.44.2015.01.21.17.04.58 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Jan 2015 17:04:59 -0800 (PST) Sender: Warner Losh Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Subject: Re: svn commit: r277421 - head/sys/powerpc/powerpc From: Warner Losh In-Reply-To: <20150121075410.GM42409@kib.kiev.ua> Date: Wed, 21 Jan 2015 18:04:57 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <81FEE3A9-C522-48A3-9292-893685C640AF@bsdimp.com> References: <201501201621.t0KGLx26096724@svn.freebsd.org> <20150120191438.GL42409@kib.kiev.ua> <54BF240C.2090107@freebsd.org> <20150121075410.GM42409@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.1993) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Nathan Whitehorn X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2015 01:05:00 -0000 > On Jan 21, 2015, at 12:54 AM, Konstantin Belousov = wrote: >=20 > On Tue, Jan 20, 2015 at 07:59:08PM -0800, Nathan Whitehorn wrote: >>=20 >> On 01/20/15 11:14, Konstantin Belousov wrote: >>> On Tue, Jan 20, 2015 at 04:21:59PM +0000, Nathan Whitehorn wrote: >>>> Author: nwhitehorn >>>> Date: Tue Jan 20 16:21:59 2015 >>>> New Revision: 277421 >>>> URL: https://svnweb.freebsd.org/changeset/base/277421 >>>>=20 >>>> Log: >>>> There does not seem to be any reason to acquire GIANT here. = Follow amd64 >>>> in removing it. >>>>=20 >>>> MFC after: 1 month >>>>=20 >>>> Modified: >>>> head/sys/powerpc/powerpc/mem.c >>>>=20 >>>> Modified: head/sys/powerpc/powerpc/mem.c >>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>> --- head/sys/powerpc/powerpc/mem.c Tue Jan 20 15:45:09 2015 = (r277420) >>>> +++ head/sys/powerpc/powerpc/mem.c Tue Jan 20 16:21:59 2015 = (r277421) >>>> @@ -100,8 +100,6 @@ memrw(struct cdev *dev, struct uio *uio, >>>> cnt =3D 0; >>>> error =3D 0; >>>>=20 >>>> - GIANT_REQUIRED; >>>> - >>> This is not an acquisition, to be pedantic. Really, it is cdevsw = which >>> has D_NEEDGIANT flag which acquires Giant. After architectures get >>> rid of GIANT_REQUIRED, flag can be removed. >>>=20 >> Just so I understand, you are not objecting to this commit, right? > Absolutely not, this is the right thing to do. >=20 >> Just=20 >> pointing out that (a) my commit message was wrong and that (b) once = all=20 >> architectures make this change (presumably more involved) we can get = rid=20 >> of the D_NEEDGIANT in /sys/dev/mem/memdev.c? > Exactly. There doesn=E2=80=99t seem to be a reason for i386 either. Was just = looking at the code today on the plane for unrelated reasons. Warner