From owner-cvs-src@FreeBSD.ORG Tue Feb 28 16:07:46 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BBAD016A420; Tue, 28 Feb 2006 16:07:46 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F36B43D45; Tue, 28 Feb 2006 16:07:46 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.ntplx.net (8.13.5/8.13.5/NETPLEX) with ESMTP id k1SG7jvS013983; Tue, 28 Feb 2006 11:07:45 -0500 (EST) Date: Tue, 28 Feb 2006 11:07:45 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Xin LI In-Reply-To: <20060228075203.GA74787@hub.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/rpc auth_des.c auth_none.c auth_unix.c clnt_dg.c clnt_raw.c clnt_simple.c clnt_vc.c getpublickey.c key_call.c mt_misc.c mt_misc.h rpc_com.h rpc_generic.c rpc_soc.c rpcb_cl X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2006 16:07:46 -0000 On Tue, 28 Feb 2006, Xin LI wrote: > Hi, > > On Mon, Feb 27, 2006 at 10:10:59PM +0000, Daniel Eischen wrote: > > deischen 2006-02-27 22:10:59 UTC > > > > FreeBSD src repository > > > > Modified files: > > lib/libc/rpc auth_des.c auth_none.c auth_unix.c > > clnt_dg.c clnt_raw.c clnt_simple.c > > clnt_vc.c getpublickey.c key_call.c > > mt_misc.c rpc_com.h rpc_generic.c > > rpc_soc.c rpcb_clnt.c svc.c svc_auth.c > > svc_dg.c svc_generic.c svc_raw.c > > svc_run.c svc_simple.c svc_vc.c > > Added files: > > lib/libc/rpc mt_misc.h > > I think we used to have a compiler bug which has hidden the > API inconsistency where yp related functions having weak > constant constraints, while the other part in libc do. > > Seems that getpublickey.c change has triggered the compiler > to (correctly) generate warnings about the const/variable > inconsistency, and thus broken the world... Perhaps we > should add const constraint for certain yp related stuff? I just committed a fix for this one particular problem. I never got the error with my previous builds because I had CFLAGS=-O -pipe in my /etc/make.conf. I didn't test this with a buildworld, but I did make sure that librpcsvc built, and that is the only consumer of getpublicandprivatekey() that I found in our src tree. -- DE