From owner-svn-src-all@FreeBSD.ORG Mon Apr 20 16:36:20 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 88AD2C99; Mon, 20 Apr 2015 16:36:20 +0000 (UTC) Received: from mail-qk0-x22a.google.com (mail-qk0-x22a.google.com [IPv6:2607:f8b0:400d:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 42F69C9C; Mon, 20 Apr 2015 16:36:20 +0000 (UTC) Received: by qkgx75 with SMTP id x75so184837992qkg.1; Mon, 20 Apr 2015 09:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=6/hR8f7w8gi3WX8hGJa7ggTk9khtC2eQ6KgDnbCY3k8=; b=JI+z5kEvLLsbR3qnysoEvPSBeoKG6EQ07ri1E6umrJlCYhV7OrMKxx9rqF8EuxOScu 1QlglNA557ccZe7kWB471INlBqfZSkN/JP5hKAja7Wzi9L1KnriYRWPDJmp0QXzoAgzO QXAAQfSPaMvPcEJJeI5nlIj2R3GeCL9PUlPr1vHvWxoh4V/kKIHtHuc6AFFy0Giwh7Ch afI/W83IvRG3sng9FvNTe0mKuoQ9wZamPHUy/jGLh6TwUKk7ZTryBWEWcDaQFMTfhFGR aeyQnqjqgchZd3hu8vp1A2KifwyjaMmbd+kQZk5B28DhzkVEtk90bo2gco7s5fbkyNV6 +sxQ== MIME-Version: 1.0 X-Received: by 10.55.20.30 with SMTP id e30mr30189925qkh.45.1429547779427; Mon, 20 Apr 2015 09:36:19 -0700 (PDT) Sender: chmeeedalf@gmail.com Received: by 10.140.84.179 with HTTP; Mon, 20 Apr 2015 09:36:19 -0700 (PDT) In-Reply-To: <20150421020808.D10623@besplex.bde.org> References: <201504190033.t3J0XMDX041769@svn.freebsd.org> <476583045.Qcb6O2DFtY@ralph.baldwin.cx> <20150421020808.D10623@besplex.bde.org> Date: Mon, 20 Apr 2015 09:36:19 -0700 X-Google-Sender-Auth: JRhvpZKjPh_YfFQOmNTqzQNDaTc Message-ID: Subject: Re: svn commit: r281721 - head/sys/sys From: Justin Hibbits To: Bruce Evans Cc: John Baldwin , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2015 16:36:20 -0000 On Mon, Apr 20, 2015 at 9:19 AM, Bruce Evans wrote: > On Mon, 20 Apr 2015, John Baldwin wrote: > >> On Sunday, April 19, 2015 12:33:22 AM Justin Hibbits wrote: >>> >>> Log: >>> Fix the build. Commit the last part of e500 PMC. >>> ... >>> @@ -136,6 +138,7 @@ enum pmc_cputype { >>> __PMC_CLASS(MIPS74K) /* MIPS 74K */ \ >>> __PMC_CLASS(PPC7450) /* Motorola MPC7450 class */ \ >>> __PMC_CLASS(PPC970) /* IBM PowerPC 970 class */ \ >>> + __PMC_CLASS(E500) /* Freescale e500 class */ \ >>> __PMC_CLASS(SOFT) /* Software events */ >> >> >> Note that each time a PMC_CLASS is added, the ABI for pmccontrol -L >> breaks since the enum value of the "SOFT" class changes. We should >> perhaps fix the value of SOFT to make this less painful (just as we >> fix the values for PMC_CPU so that those don't change). > > > Enums should never be used in ABIs, since their size can be anything > large enough. > > They also cause namespace problems. The whole enum declaration must > be exposed in any header that uses an enum type. > > Bruce Any change breaks ABI for any architecture listed after anyway (Adrian's MIPS74K broke all PowerPC). Could we not take the same IDs as in pmc_events.h to generate the PM_CLASS IDs? - Justin