From owner-freebsd-ports-bugs@FreeBSD.ORG Fri May 9 08:50:02 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1DD14310 for ; Fri, 9 May 2014 08:50:02 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EF59EA74 for ; Fri, 9 May 2014 08:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s498o17V033239 for ; Fri, 9 May 2014 08:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s498o1it033238; Fri, 9 May 2014 08:50:01 GMT (envelope-from gnats) Resent-Date: Fri, 9 May 2014 08:50:01 GMT Resent-Message-Id: <201405090850.s498o1it033238@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, George Amanakis Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EA24BF63 for ; Fri, 9 May 2014 08:40:16 +0000 (UTC) Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE3E7972 for ; Fri, 9 May 2014 08:40:16 +0000 (UTC) Received: from cgiserv.freebsd.org ([127.0.1.6]) by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s498eGpD014756 for ; Fri, 9 May 2014 08:40:16 GMT (envelope-from nobody@cgiserv.freebsd.org) Received: (from nobody@localhost) by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s498eGQf014755; Fri, 9 May 2014 08:40:16 GMT (envelope-from nobody) Message-Id: <201405090840.s498eGQf014755@cgiserv.freebsd.org> Date: Fri, 9 May 2014 08:40:16 GMT From: George Amanakis To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/189497: Deluge not downloading blocklist X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 May 2014 08:50:02 -0000 >Number: 189497 >Category: ports >Synopsis: Deluge not downloading blocklist >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri May 09 08:50:01 UTC 2014 >Closed-Date: >Last-Modified: >Originator: George Amanakis >Release: 9.2-RELEASE-p5 >Organization: >Environment: FreeBSD hostname 9.2-RELEASE-p5 FreeBSD 9.2-RELEASE-p5 #1: Mon May 5 11:10:55 CEST 2014 root@hostname:/usr/obj/usr/src/sys/GEN_ipsec_altq amd64 >Description: The following bug exists on the port of Deluge: Enabling the Blocklist plugin and attempting to download a list fails. The scenario was tested with deluged running as daemon on FreeBSD (built from ports) and a remote GTK-Interface on Windows (official prebuild-binaries) or on Archlinux (through the official repo). Culprit is the httpdownloader.py has not been updated to work with twisted > 13.1.0. >How-To-Repeat: See above. >Fix: The following patch resolves the problem: --- httpdownloader.py.org 2014-05-08 23:36:46.000000000 +0200 +++ httpdownloader.py 2014-05-09 00:05:43.000000000 +0200 @@ -191,8 +191,18 @@ if not headers: headers = {} headers["accept-encoding"] = "deflate, gzip, x-gzip" + +# In twisted 13.1.0 the _parse() function was replaced by the _URI class + if hasattr(client, '_parse'): + scheme, host, port, path = client._parse(url) + else: + from twisted.web.client import _URI + uri = _URI.fromBytes(url) + scheme = uri.scheme + host = uri.host + port = uri.port + path = uri.path - scheme, host, port, path = client._parse(url) factory = HTTPDownloader(url, filename, callback, headers, force_filename, allow_compression) if scheme == "https": from twisted.internet import ssl Patch attached with submission follows: --- httpdownloader.py.org 2014-05-08 23:36:46.000000000 +0200 +++ httpdownloader.py 2014-05-09 00:05:43.000000000 +0200 @@ -191,8 +191,18 @@ if not headers: headers = {} headers["accept-encoding"] = "deflate, gzip, x-gzip" + +# In twisted 13.1.0 the _parse() function was replaced by the _URI class + if hasattr(client, '_parse'): + scheme, host, port, path = client._parse(url) + else: + from twisted.web.client import _URI + uri = _URI.fromBytes(url) + scheme = uri.scheme + host = uri.host + port = uri.port + path = uri.path - scheme, host, port, path = client._parse(url) factory = HTTPDownloader(url, filename, callback, headers, force_filename, allow_compression) if scheme == "https": from twisted.internet import ssl >Release-Note: >Audit-Trail: >Unformatted: