From owner-freebsd-net@FreeBSD.ORG  Fri Jun 10 22:12:20 2005
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8161316A41C;
	Fri, 10 Jun 2005 22:12:20 +0000 (GMT)
	(envelope-from is@rambler-co.ru)
Received: from yam.park.rambler.ru (yam.park.rambler.ru [81.19.64.116])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1FCF243D1F;
	Fri, 10 Jun 2005 22:12:18 +0000 (GMT)
	(envelope-from is@rambler-co.ru)
Received: from is.park.rambler.ru (is.park.rambler.ru [81.19.64.102])
	by yam.park.rambler.ru (8.13.3/8.13.3) with ESMTP id j5AMCG0S013844;
	Sat, 11 Jun 2005 02:12:16 +0400 (MSD)
	(envelope-from is@rambler-co.ru)
Date: Sat, 11 Jun 2005 02:12:16 +0400 (MSD)
From: Igor Sysoev <is@rambler-co.ru>
X-X-Sender: is@is.park.rambler.ru
To: freebsd-net@freebsd.org
Message-ID: <20050611020140.R27835@is.park.rambler.ru>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Alfred Perlstein <alfred@freebsd.org>
Subject: setsockopt() can not remove the accept filter
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jun 2005 22:12:20 -0000

Hi,

man setsockopt(2) states that "passing in an optval of NULL will remove
the filter", however, setsockopt() always return EINVAL in this case,
because do_setopt_accept_filter() removes the filter if sopt == NULL, but
not if sopt->val == NULL.  The fix is easy:

-        if (sopt == NULL) {
+        if (sopt == NULL || sopt->val == NULL) {


By the way, is it easy to add timeout for dataready and httpready filters ?
Now the stale connections may live for long time.


Igor Sysoev
http://sysoev.ru/en/