From owner-freebsd-net@FreeBSD.ORG Fri Apr 9 11:31:27 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B30AD16A4D8; Fri, 9 Apr 2004 11:31:25 -0700 (PDT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id B730943D31; Fri, 9 Apr 2004 11:31:24 -0700 (PDT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i39IZmeO008156 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 9 Apr 2004 21:35:49 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.12.11/8.12.11) id i39IVHOZ003553; Fri, 9 Apr 2004 21:31:17 +0300 (EEST) (envelope-from ru) Date: Fri, 9 Apr 2004 21:31:17 +0300 From: Ruslan Ermilov To: Luigi Rizzo Message-ID: <20040409183117.GA3431@ip.net.ua> References: <20040409164724.GD2461@ip.net.ua> <20040409105503.A35357@xorpc.icir.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC" Content-Disposition: inline In-Reply-To: <20040409105503.A35357@xorpc.icir.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: net@FreeBSD.org Subject: Re: polling(4) and rl(4) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2004 18:31:28 -0000 --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 09, 2004 at 10:55:03AM -0700, Luigi Rizzo wrote: > On Fri, Apr 09, 2004 at 07:47:24PM +0300, Ruslan Ermilov wrote: > > Hey Luigi, > >=20 > > Have you actually measured the performance of rl(4) with polling(4) > > enabled? With 8139 anomaly of four (register based) TX descriptors >=20 > no, nor i did expect any improvement -- the code was only there > to help when the 8139C+ was supported. But now that happens in > a different driver. >=20 > Re. the removal, I still think it is beneficial in receiving, > (not performancewise, just to avoid livelock), so as a temporary > measure why don't you just short-circuit the logic that enables > polling in the driver rather than ripping it out completely ? >=20 Do you mean it would be okay if I just trimmed the polling support in rl(4) to the RX part only? I actually considered doing this, just wasn't sure if it is good. ;) Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAduv1Ukv4P6juNwoRAssPAJ9QiMqckiATbBQh9VTmveMw4oYsQQCfV/nf 6vi5OE1MbE5v5eNYJY4wZx8= =Y0o4 -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC--