From owner-freebsd-current@FreeBSD.ORG  Sat Nov 29 15:48:35 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4309816A4CE; Sat, 29 Nov 2003 15:48:35 -0800 (PST)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2C20643FBF; Sat, 29 Nov 2003 15:48:34 -0800 (PST)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 23CEE2ED44C; Sat, 29 Nov 2003 15:48:34 -0800 (PST)
Date: Sat, 29 Nov 2003 15:48:34 -0800
From: Alfred Perlstein <bright@mu.org>
To: Daniel Eischen <eischen@vigrid.com>
Message-ID: <20031129234834.GY35957@elvis.mu.org>
References: <20031129202138.GU35957@elvis.mu.org>
	<Pine.GSO.4.10.10311291753400.10943-100000@pcnet5.pcnet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.GSO.4.10.10311291753400.10943-100000@pcnet5.pcnet.com>
User-Agent: Mutt/1.4.1i
cc: re@freebsd.org
cc: current@freebsd.org
Subject: Re: [PATCH] please review. file descriptor passing for libc_r.
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2003 23:48:35 -0000

* Daniel Eischen <eischen@vigrid.com> [031129 14:57] wrote:
> > 
> > What do you suggest we do?
> 
> Just close the file:
> 
> 	if ((fd < 0) || (fd >= _thread_dtablesize) ||
> 	    (fd == _thread_kern_pipe[0]) || (fd == _thread_kern_pipe[1])) {
> 		/*
> 		 * Don't allow silly programs to close the kernel pipe
> 		 * and non-active descriptors.
> 		 */
> 		errno = EBADF;
> 		ret = -1;
> 	}
> 	else if (_thread_fd_table[fd] == NULL)
> 		ret = __sys_close(fd);
> 	else {
> 		...
> 	}

So remove the check?  do you approve? does re@ approve?

Index: uthread_close.c
===================================================================
RCS file: /home/ncvs/src/lib/libc_r/uthread/uthread_close.c,v
retrieving revision 1.16
diff -u -r1.16 uthread_close.c
--- uthread_close.c	9 Jun 2003 16:45:37 -0000	1.16
+++ uthread_close.c	29 Nov 2003 23:48:14 -0000
@@ -50,8 +50,7 @@
 	struct fd_table_entry	*entry;
 
 	if ((fd < 0) || (fd >= _thread_dtablesize) ||
-	    (fd == _thread_kern_pipe[0]) || (fd == _thread_kern_pipe[1]) ||
-	    (_thread_fd_table[fd] == NULL)) {
+	    (fd == _thread_kern_pipe[0]) || (fd == _thread_kern_pipe[1]))
 		/*
 		 * Don't allow silly programs to close the kernel pipe
 		 * and non-active descriptors.

--
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684