From owner-cvs-src@FreeBSD.ORG Tue Apr 24 16:00:20 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CF26216A400; Tue, 24 Apr 2007 16:00:20 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 6E3DA13C459; Tue, 24 Apr 2007 16:00:20 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l3OFxgsn058451; Tue, 24 Apr 2007 11:59:42 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Yar Tikhiy Date: Tue, 24 Apr 2007 11:46:27 -0400 User-Agent: KMail/1.9.6 References: <200704211417.l3LEHUKK078832@repoman.freebsd.org> <1177170852.32761.0.camel@localhost> <20070424091858.GA31094@comp.chem.msu.su> In-Reply-To: <20070424091858.GA31094@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704241146.28303.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 24 Apr 2007 11:59:42 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3155/Tue Apr 24 09:27:10 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, Andre Oppermann , cvs-src@freebsd.org, cvs-all@freebsd.org, Stephan Uphoff , Coleman Kane Subject: Re: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2007 16:00:20 -0000 On Tuesday 24 April 2007 05:18:59 am Yar Tikhiy wrote: > On Sat, Apr 21, 2007 at 09:54:12AM -0600, Coleman Kane wrote: > > On Sat, 2007-04-21 at 17:03 +0200, Andre Oppermann wrote: > > > Stephan Uphoff wrote: > > > > ups 2007-04-21 14:17:30 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/amd64/amd64 pmap.c > > > > sys/i386/i386 pmap.c > > > > Log: > > > > Modify TLB invalidation handling. > > > > > > > > Reviewed by: alc@, peter@ > > > > MFC after: 1 week > > > > > > Could you be a bit more verbose what changed here and why it > > > was done? > > > > > > > I agree. I would really like to know what the modification accomplishes. > > Alas, we don't live in an ideal world. If we did, our commit > messages would always follow the well-known guideline: > > 0. Tell the essence of the change. > 1. Give the reason for the change. > 2. Explain the change unless it's trivial. The point of the modification is to make sure we don't clear TLB entries for pages whose mappings are being removed until we've also made any necessary updates to other entries higher in the page table hierarchy such as pde's etc. We've seen some really bizarre "bad pte" panics at work that this change fixes. -- John Baldwin