From owner-cvs-src@FreeBSD.ORG Mon Jun 11 19:08:10 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F31CD16A41F; Mon, 11 Jun 2007 19:08:09 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id A2BC913C43E; Mon, 11 Jun 2007 19:08:09 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l5BJ85f8071263; Mon, 11 Jun 2007 13:08:06 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <466D9D94.1020908@samsco.org> Date: Mon, 11 Jun 2007 13:08:04 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.4) Gecko/20070509 SeaMonkey/1.1.2 MIME-Version: 1.0 To: Andre Oppermann References: <200706111459.l5BExvTp020932@repoman.freebsd.org> <466D9BBB.1060601@freebsd.org> In-Reply-To: <466D9BBB.1060601@freebsd.org> X-Enigmail-Version: 0.95.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Mon, 11 Jun 2007 13:08:06 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, Andrew Gallatin , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/sys mbuf.h src/sys/net if_ethersubr.c src/sys/dev/mxge mxge_lro.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2007 19:08:10 -0000 Andre Oppermann wrote: > Andrew Gallatin wrote: >> gallatin 2007-06-11 14:59:56 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/sys mbuf.h sys/net >> if_ethersubr.c sys/dev/mxge mxge_lro.c Log: >> Allow drivers, such as cxgb and mxge, which support LRO to bypass >> the MTU check in ether_input() on LRO merged frames. >> Discussed with: kmacy > > Not discussed with: andre > > Your change isn't the right way to make this work. LRO is an interface > capability (that should have the option to disable it) and the test in > ether_input() should go on that instead. LRO is not an information > that is needed beyond ether_input() and thus doesn't have to be a mbuf > flag. > > I've indicated that I'm working in this area as well and at least > dropping an email or a ping IRC would have been nice. I would have > told you the above right away. My common version of LRO isn't ready > yet as I'm a bit short on time and I chose to concentrate on TCP it- > self. We only have to make sure that we don't exclude a common LRO > implementation due to API/ABI issues for 7.1R. > Drew's commit looks simple and non-obtrusive enough that it can likely be replaced once your perfected LRO implementation is done and in the tree. Until that happens, I can't imagine a good reason to block his and Kip's work. Scott