From owner-freebsd-ipfw@FreeBSD.ORG  Tue May 31 09:40:10 2011
Return-Path: <owner-freebsd-ipfw@FreeBSD.ORG>
Delivered-To: freebsd-ipfw@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CAFAB106566B
	for <freebsd-ipfw@hub.freebsd.org>;
	Tue, 31 May 2011 09:40:10 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id BBE258FC1F
	for <freebsd-ipfw@hub.freebsd.org>;
	Tue, 31 May 2011 09:40:10 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p4V9eARt028023
	for <freebsd-ipfw@freefall.freebsd.org>; Tue, 31 May 2011 09:40:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p4V9eA15028022;
	Tue, 31 May 2011 09:40:10 GMT (envelope-from gnats)
Date: Tue, 31 May 2011 09:40:10 GMT
Message-Id: <201105310940.p4V9eA15028022@freefall.freebsd.org>
To: freebsd-ipfw@FreeBSD.org
From: "skeletor@lissyara.su" <skeletor@lissyara.su>
Cc: 
Subject: Re: kern/147720: [ipfw] ipfw dynamic rules and fwd
X-BeenThere: freebsd-ipfw@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: "skeletor@lissyara.su" <skeletor@lissyara.su>
List-Id: IPFW Technical Discussions <freebsd-ipfw.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ipfw>
List-Post: <mailto:freebsd-ipfw@freebsd.org>
List-Help: <mailto:freebsd-ipfw-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 May 2011 09:40:10 -0000

The following reply was made to PR kern/147720; it has been noted by GNATS.

From: "skeletor@lissyara.su" <skeletor@lissyara.su>
To: bug-followup@FreeBSD.org, dima_bsd@inbox.lv
Cc:  
Subject: Re: kern/147720: [ipfw] ipfw dynamic rules and fwd
Date: Tue, 31 May 2011 12:03:53 +0300

 Hello!
 I have tested the NEW following code on FreeBSD 8.2 Release i386 and it 
 works!
 
 New CODE (patched)
 
 ...
 case O_FORWARD_IP: {
 +	struct sockaddr_in *sa;
 +	sa = &(((ipfw_insn_sa *)cmd)->sa);
 	if (args->eh)<->/* not valid on layer2 pkts */
 		break;
 +	if (!q || dyn_dir == MATCH_FORWARD || sa->sin_port == 0) {
 -	if (!q || dyn_dir == MATCH_FORWARD) {
 -	struct sockaddr_in *sa;
 -	sa = &(((ipfw_insn_sa *)cmd)->sa);
 ...
 
 
 This code was patched by Vadim Goncharov and tested by me (skeletor).