From owner-cvs-src@FreeBSD.ORG  Tue Nov 15 09:59:00 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3E88116A443;
	Tue, 15 Nov 2005 09:59:00 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BD86A43D46;
	Tue, 15 Nov 2005 09:58:59 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 6DF3B46B4F;
	Tue, 15 Nov 2005 04:58:52 -0500 (EST)
Date: Tue, 15 Nov 2005 09:58:52 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Alexander Leidinger <Alexander@Leidinger.net>
In-Reply-To: <20051115105128.a5dd001i0ckock0s@netchild.homeip.net>
Message-ID: <20051115095801.M61850@fledge.watson.org>
References: <200511150419.jAF4JRUp080869@repoman.freebsd.org>
	<20051115105128.a5dd001i0ckock0s@netchild.homeip.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: src-committers@FreeBSD.org, ariff@FreeBSD.org,
	Alexander Kabaev <kan@FreeBSD.org>, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org, arr@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/sound/pcm channel.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Nov 2005 09:59:01 -0000


On Tue, 15 Nov 2005, Alexander Leidinger wrote:

>>  Modified files:
>>    sys/dev/sound/pcm    channel.c
>>  Log:
>>  Unbreak kernel builds.
>> 
>>  Submitted by:   arr
>
> Hos does the change from "min & (min-1) == 0" to "(min & (min-1)) == 0" 
> fix the building of a kernel (what was the error message from gcc)?

Probably a combination of -Wall and -Werror, which generally generates a 
warning along the following lines:

     warning: suggest parentheses around comparison in operand of &

Robert N M Watson