From owner-freebsd-hackers  Mon Mar  3 21:59:21 1997
Return-Path: <owner-hackers>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id VAA26525
          for hackers-outgoing; Mon, 3 Mar 1997 21:59:21 -0800 (PST)
Received: from genesis.atrad.adelaide.edu.au (genesis.atrad.adelaide.edu.au [129.127.96.120])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id VAA26520
          for <hackers@FreeBSD.ORG>; Mon, 3 Mar 1997 21:59:16 -0800 (PST)
Received: (from msmith@localhost) by genesis.atrad.adelaide.edu.au (8.8.5/8.7.3) id QAA11070; Tue, 4 Mar 1997 16:29:06 +1030 (CST)
From: Michael Smith <msmith@atrad.adelaide.edu.au>
Message-Id: <199703040559.QAA11070@genesis.atrad.adelaide.edu.au>
Subject: Re: xemacs crashes kernel
In-Reply-To: <19970303235057.26399@right.PCS> from Jonathan Lemon at "Mar 3, 97 11:50:57 pm"
To: jlemon@americantv.com (Jonathan Lemon)
Date: Tue, 4 Mar 1997 16:29:05 +1030 (CST)
Cc: msmith@atrad.adelaide.edu.au, proff@iq.org, hackers@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL28 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-hackers@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Jonathan Lemon stands accused of saying:
> 
> I changed the fsync code to read:
> 
>         error = VOP_FSYNC(vp, fp->f_cred,
>                 (vp->v_mount && (vp->v_mount->mnt_flag & MNT_ASYNC)) ? 
>                 MNT_NOWAIT : MNT_WAIT, p);
> 
> And it doesn't crash the kernel any more.  I'm not sure if this is 
> the right fix or not.  Julian - you might want to try this as well.

It might be.  The MFS appears to be the culprit, courtesy of this in
mfs_vfsops.c/mfs_mount() :

        err = getnewvnode(VT_MFS, (struct mount *)0, mfs_vnodeop_p, &devvp);

Every other filesystem mount routine passes it's (mp) arg here,
but this sucker passes 0. 

Filesystem people, Is This a Bug?  (I can't do the raspy voice while
typing 8)

> Jonathan

-- 
]] Mike Smith, Software Engineer        msmith@gsoft.com.au             [[
]] Genesis Software                     genesis@gsoft.com.au            [[
]] High-speed data acquisition and      (GSM mobile)     0411-222-496   [[
]] realtime instrument control.         (ph)          +61-8-8267-3493   [[
]] Unix hardware collector.             "Where are your PEZ?" The Tick  [[