From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Sep 5 02:40:03 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 998CA10656BC for ; Sun, 5 Sep 2010 02:40:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5C8928FC1D for ; Sun, 5 Sep 2010 02:40:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o852e39K020785 for ; Sun, 5 Sep 2010 02:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o852e3gb020784; Sun, 5 Sep 2010 02:40:03 GMT (envelope-from gnats) Resent-Date: Sun, 5 Sep 2010 02:40:03 GMT Resent-Message-Id: <201009050240.o852e3gb020784@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Erick Crager Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B8F1810656CD for ; Sun, 5 Sep 2010 02:32:35 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 8DC358FC13 for ; Sun, 5 Sep 2010 02:32:35 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o852WZoj027063 for ; Sun, 5 Sep 2010 02:32:35 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o852WZpG027062; Sun, 5 Sep 2010 02:32:35 GMT (envelope-from nobody) Message-Id: <201009050232.o852WZpG027062@www.freebsd.org> Date: Sun, 5 Sep 2010 02:32:35 GMT From: Erick Crager To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/150294: hellanzb fails to run due to string compare bug X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Sep 2010 02:40:03 -0000 >Number: 150294 >Category: ports >Synopsis: hellanzb fails to run due to string compare bug >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 05 02:40:03 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Erick Crager >Release: 8.1-RELEASE >Organization: >Environment: FreeBSD bastion.local 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:36:49 UTC 2010 root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: hellanzb.py does not function properly when built from ports. It seems the version from ports has a string comparison bug in /usr/local/lib/python2.6/site-packages/Hellanzb/HellaReactor.py. I have attached a very simple fix to this bug report that should correct the problem. >How-To-Repeat: 1. Install news/hellanzb from ports. 2. Try to run it: `hellanzb.py`. You will see: $ hellanzb.py /usr/local/lib/python2.6/site-packages/twisted/internet/default.py:15: DeprecationWarning: twisted.internet.default is deprecated. Use posixbase or selectreactor instead. warnings.warn("twisted.internet.default is deprecated. Use posixbase or selectreactor instead.", category=DeprecationWarning) Traceback (most recent call last): File "/usr/local/bin/hellanzb.py", line 14, in from Hellanzb.Core import main File "/usr/local/lib/python2.6/site-packages/Hellanzb/Core.py", line 9, in from Hellanzb.HellaReactor import HellaReactor File "/usr/local/lib/python2.6/site-packages/Hellanzb/HellaReactor.py", line 19, in from twisted.internet.default import _NO_FILENO ImportError: cannot import name _NO_FILENO >Fix: Here is a simple one-line fix for the problem: $ diff -u /usr/local/lib/python2.6/site-packages/Hellanzb/HellaReactor.py HellaReactor.py --- /usr/local/lib/python2.6/site-packages/Hellanzb/HellaReactor.py 2010-09-04 19:28:03.000000000 -0700 +++ HellaReactor.py 2010-09-04 19:26:56.000000000 -0700 @@ -9,7 +9,7 @@ import Hellanzb, sys, time import twisted.copyright -if twisted.copyright.version >= '2.0.0': +if float(twisted.copyright.version.split('.',1)[0]) >= 2.0: from twisted.internet.selectreactor import SelectReactor from twisted.internet.selectreactor import _NO_FILENO from twisted.internet.selectreactor import _NO_FILEDESC >Release-Note: >Audit-Trail: >Unformatted: