From owner-freebsd-current@FreeBSD.ORG Mon Sep 22 19:21:49 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E2AD7B38; Mon, 22 Sep 2014 19:21:49 +0000 (UTC) Received: from mailout04.t-online.de (mailout04.t-online.de [194.25.134.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mailout00.t-online.de", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9F483A92; Mon, 22 Sep 2014 19:21:49 +0000 (UTC) Received: from fwd24.aul.t-online.de (fwd24.aul.t-online.de [172.20.26.129]) by mailout04.t-online.de (Postfix) with SMTP id CCB6336769A; Mon, 22 Sep 2014 21:15:25 +0200 (CEST) Received: from [192.168.119.10] (X7AZigZZQh2eqVyBZuJx9r9NqoPALGJ1aIP9sE8xnOZivG2OtG9w3-xJ8ZJbOeNwHB@[84.154.118.168]) by fwd24.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-SHA encrypted) esmtp id 1XW951-1J2CaO0; Mon, 22 Sep 2014 21:15:23 +0200 Message-ID: <54207548.2010906@freebsd.org> Date: Mon, 22 Sep 2014 21:15:20 +0200 From: Stefan Esser User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Tijl Coosemans Subject: Re: [patch] syscons/vt keymap: Norwegian country code conflicts with default value References: <20140921183936.03617590@onyx.thanelange.no> <54201192.5080906@freebsd.org> <20140922192844.7de1bb6b@kalimero.tijl.coosemans.org> In-Reply-To: <20140922192844.7de1bb6b@kalimero.tijl.coosemans.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-ID: X7AZigZZQh2eqVyBZuJx9r9NqoPALGJ1aIP9sE8xnOZivG2OtG9w3-xJ8ZJbOeNwHB X-TOI-MSGID: 2e1c4859-7c55-4392-b730-90e921824b81 Cc: Gyrd Thane Lange , freebsd-current@freebsd.org, freebsd-stable stable X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2014 19:21:50 -0000 Am 22.09.2014 um 19:28 schrieb Tijl Coosemans: > On Mon, 22 Sep 2014 14:09:54 +0200 Stefan Esser wrote: >> Am 21.09.2014 um 18:39 schrieb Gyrd Thane Lange: >>> Hi, >>> >>> Recent changes in keymap namning for syscons/vt to use shorter names >>> has exposed a conflict with the value "no" both used as country code >>> for Norway and as a default value indicating that no keymap is set. >>> >>> The attached patch proposes to use "" (empty string) as default value >>> instead. >> >> Hi Gyrd, >> >> thank you for reporting the issue! >> >> I have just committed a slightly different patch to -CURRENT and plan >> to merge it to 10-STABLE in time for the next BETA. >> >> You may want to check-out r271958 ... >> >> >> The approach I have chosen it to let "NO" continue to stand for "do >> not load any keymap", while "no" is now recognized as equivalent to >> "no.kbd". >> >> >> The new semantics of the keymap parameter in rc.conf are: >> >> keymap='' ==> do not load any keymap (unchanged) >> keymap=NO ==> do not load any keymap (unchanged) >> keymap=no ==> load Norwegian keymap (new) >> >> This may still catch people that have edited rc.conf to use "no" in >> the meaning "no keymap" by accident, but I see no other approach that >> better complies with POLA ... > > Maybe NONE. It's already being used in a number of cases. This was one of the alternatives, which I considered before the commit. Reasons for my choice of "no" vs. "NO" (and not "NONE"): 1) NO is the default (in defaults/rc.conf) and may have found its way into individual rc.conf files. I wanted to preserve its meaning. 2) Tools like bsdconfig need to be made version aware and to use NO for releases before 10.1 and NONE for 10.1 and later. IIRC, the use of NONE in rc.conf should be limited to cases that need a value besides NO (e.g. in the case of sendmail_enable, where both NO and NONE have special meaning). If there are no strong arguments against the patch that I committed, I'd like to MFC it to -STABLE. But if there are better alternatives (and I do not think that "NONE" is better, sorry), I'd like to hear about them in time for BETA3 ... Regards, STefan