From owner-cvs-all Sun Oct 28 21:46:17 2001 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 6F2C737B401; Sun, 28 Oct 2001 21:46:11 -0800 (PST) Received: from localhost (arr@localhost) by fledge.watson.org (8.11.6/8.11.5) with SMTP id f9T5k3033266; Mon, 29 Oct 2001 00:46:03 -0500 (EST) (envelope-from arr@watson.org) Date: Mon, 29 Oct 2001 00:46:02 -0500 (EST) From: "Andrew R. Reiter" To: Luigi Rizzo Cc: Josef Karthauser , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: ipfw.c -- (was: cvs commit: src/sys/netinet ip_fw.h) In-Reply-To: <20011028212026.A94510@iguana.aciri.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 28 Oct 2001, Luigi Rizzo wrote: : :actually it is _good_ design to declare variables as local as :possible, because it enables the compiler to detect more erroneous :use of the same. I can agree with the good design, but Im speaking on behalf of style 9. As discussed before, style.9 is not the "best" way things should be done, but unless the definition is changed, I think it would be wise to adhere to the guidelines. Am I wrong about the style 9 definition? I know there've been a number of recent changes... Cheers, Andrew *-------------................................................. | Andrew R. Reiter | arr@fledge.watson.org | "It requires a very unusual mind | to undertake the analysis of the obvious" -- A.N. Whitehead To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message