From owner-svn-ports-head@FreeBSD.ORG Mon Aug 20 07:57:14 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 83401106566B; Mon, 20 Aug 2012 07:57:14 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from micro.madpilot.net (micro.madpilot.net [88.149.173.206]) by mx1.freebsd.org (Postfix) with ESMTP id D1E1C8FC0A; Mon, 20 Aug 2012 07:57:13 +0000 (UTC) Received: from micro.madpilot.net (localhost [127.0.0.1]) by micro.madpilot.net (Postfix) with ESMTP id 3X0nRX2Fbkz1nR; Mon, 20 Aug 2012 09:57:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=madpilot.net; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:message-id:subject:subject :from:from:date:date:received:received; s=mail; t=1345449429; x= 1347263830; bh=F4BRntEN8YhUBJxx4Hgj7CSrYddOWp1Me/jUKJCQFdw=; b=M RjIvZ1efaf0yH3T/Tjp+V+In9rt9ZZY/7mXlHvTBuVXEaBi0LODx7aYa+qjioBPa VIWd0WHB+UGPHOrxMsh1dTtAdflQO6IUqwsH14aKMeDr5d7fRuVafoLkdb+yiAvj sMPQTp4GyRtWysCS3KWyKM2o5S6SPbQ1uV60DU+WuM= X-Virus-Scanned: amavisd-new at madpilot.net Received: from micro.madpilot.net ([127.0.0.1]) by micro.madpilot.net (micro.madpilot.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id G297pzuLyhHD; Mon, 20 Aug 2012 09:57:09 +0200 (CEST) Received: by micro.madpilot.net (Postfix, from userid 1000) id 3X0nRT5PkXz1nQ; Mon, 20 Aug 2012 09:57:09 +0200 (CEST) Date: Mon, 20 Aug 2012 09:57:09 +0200 From: Guido Falsi To: Jason Helfman Message-ID: <20120820075709.GA72904@micro.madpilot.net> References: <201208191707.q7JH7tZ8011378@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 9.1-PRERELEASE User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, Chris Rees , svn-ports-all@freebsd.org, Thomas Abthorpe , ports-committers@freebsd.org Subject: Re: svn commit: r302766 - head/games/moagg X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2012 07:57:14 -0000 On Sun, Aug 19, 2012 at 02:41:24PM -0700, Jason Helfman wrote: > On Sun, Aug 19, 2012 at 10:07 AM, Guido Falsi wrote: > > > Author: madpilot > > Date: Sun Aug 19 17:07:55 2012 > > New Revision: 302766 > > URL: http://svn.freebsd.org/changeset/ports/302766 > > > > Log: > > - Remove own OPTION "DATA" > > - Honour NOPORTDATA instead of own option > > > > PR: ports/170736 > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=170736 > > Submitted by: nemysis (maintainer) > > Approved by: crees, tabthorpe (mentors, implicit) > > > > Modified: > > head/games/moagg/Makefile > > > > Modified: head/games/moagg/Makefile > > > > ============================================================================== > > --- head/games/moagg/Makefile Sun Aug 19 17:02:42 2012 (r302765) > > +++ head/games/moagg/Makefile Sun Aug 19 17:07:55 2012 (r302766) > > @@ -20,9 +20,6 @@ COMMENT= Pilot a small space ship > > > > LICENSE= GPLv2 > > > > -OPTIONS_DEFINE= DATA > > -OPTIONS_DEFAULT= DATA > > - > > USE_ZIP= yes > > USE_JAVA= yes > > JAVA_VERSION= 1.5+ > > @@ -47,7 +44,7 @@ do-install: > > ${INSTALL_SCRIPT} ${WRKSRC}/run.sh.new ${PREFIX}/bin/${PORTNAME} > > > > # Data > > -.if ${PORT_OPTIONS:MDATA} > > +.if !defined (NOPORTDATA) > > ${MKDIR} ${DATADIR} > > @(cd ${WRKSRC} && ${COPYTREE_SHARE} "data ghosts jar" ${DATADIR}) > > . for d in hiscores.dat log4j.properties > > > > > If it always requires DATA, per pr, why is there a check? Shouldn't DATA be > installed without a check, and > not honor NOPORTDATA? Perhaps you're right. My first idea was that the NOPORTDATA flag had the sole purpose of stopping a port to writing to DATADIR, installing the game engine without datafiles could make sense in certain situations, but I now notice the jar files too really go to datadir too...So I could agree. BTW the port already had this problem, it was just bound to the local DATA option. I'll contact the maintainer and ask him what he really prefers to do about this. -- Guido Falsi