From owner-freebsd-rc@FreeBSD.ORG Mon Feb 6 03:08:34 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 052D2106566C for ; Mon, 6 Feb 2012 03:08:34 +0000 (UTC) (envelope-from erdgeist@erdgeist.org) Received: from elektropost.org (elektropost.org [217.13.206.130]) by mx1.freebsd.org (Postfix) with ESMTP id 5209C8FC17 for ; Mon, 6 Feb 2012 03:08:32 +0000 (UTC) Received: (qmail 86145 invoked from network); 6 Feb 2012 03:12:17 -0000 Received: from elektropost.org (HELO elektropost.org) (erdgeist@erdgeist.org) by elektropost.org with CAMELLIA256-SHA encrypted SMTP; 6 Feb 2012 03:12:17 -0000 Message-ID: <4F2F442F.3030509@erdgeist.org> Date: Mon, 06 Feb 2012 04:08:31 +0100 From: Dirk Engling User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: Hiroki Sato References: <4F2F209F.90309@erdgeist.org> <20120206.101800.1389796154758679137.hrs@allbsd.org> <4F2F3459.3090401@erdgeist.org> <20120206.114622.2214566196455293098.hrs@allbsd.org> In-Reply-To: <20120206.114622.2214566196455293098.hrs@allbsd.org> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org Subject: Re: Proposal ipv6_addrs_common X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2012 03:08:34 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06.02.12 03:46, Hiroki Sato wrote: > ifconfig_tap0_aliases=" inet6 2001:db8:8888:2::1/64 inet6 > 2001:db8:9990-9999:3::1/64 inet 10.8.1.1/24 inet 10.8.0.1-10/24 " Why on earth didn't you come forward with that earlier? Would've saved me a lot of trouble. ;) The bugs in /etc/network.subr, function ifalias_up I would like to see fixed, anyway: _ret=`ifalias_ipv4_up "$1"` just does not work the way you imagined it. The return code is not passed when using _ret=`` but the command substituted by it's output on stdout, it should read: ifalias_ipv4_up ${_if} && _ret=0 as shown in my patch. > In my patch IPv6-mapped IPv4 address is not supported, but your > patch can be merged easily. I like the idea of configuring a router or DNS server for several subnets with one range as well, i.e. "inet 10.8.2-16.1/24", do you think this makes sense? > One thing in my mind is whether allowing a variable which contains > multiple lines is reasonable or not. I do not understand the problem there, does your code actually DEPEND on new lines? If not, it's just a matter of taste how to arrange your variables in your rc.conf, if it doesn't fit in 80 chars, you can either overflow, add backslashes or use the style above. The rc's author does not FORCE the user into one style, does he? erdgeist -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAk8vRC8ACgkQuN1wFypsMNN1IgCeOo5OleODoIY6gS9SMO5p5uw1 n7cAn1k4CAnlcbHBhF2hppN+SDew7483 =54g5 -----END PGP SIGNATURE-----