From owner-freebsd-hackers@FreeBSD.ORG Sat Jun 25 17:05:27 2011 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C3CD1065670 for ; Sat, 25 Jun 2011 17:05:27 +0000 (UTC) (envelope-from tim@kientzle.com) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 632778FC18; Sat, 25 Jun 2011 17:05:27 +0000 (UTC) Received: by pzk27 with SMTP id 27so3045971pzk.13 for ; Sat, 25 Jun 2011 10:05:27 -0700 (PDT) Received: by 10.68.12.3 with SMTP id u3mr2268309pbb.403.1309020100790; Sat, 25 Jun 2011 09:41:40 -0700 (PDT) Received: from [192.168.2.119] (99-74-169-43.lightspeed.sntcca.sbcglobal.net [99.74.169.43]) by mx.google.com with ESMTPS id z7sm2951761pbk.35.2011.06.25.09.41.38 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 25 Jun 2011 09:41:39 -0700 (PDT) Sender: Tim Kientzle Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Tim Kientzle In-Reply-To: <201106231620.p5NGKWD6008177@fire.js.berklix.net> Date: Sat, 25 Jun 2011 09:41:36 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <31D907F2-1F80-40B4-BDC3-486E3F988FE7@freebsd.org> References: <201106231620.p5NGKWD6008177@fire.js.berklix.net> To: Julian H. Stacey X-Mailer: Apple Mail (2.1084) Cc: hackers@freebsd.org, portsmaster@freebsd.org Subject: Re: tar has deficient error handling. send-pr fix sent 31 Jan 2011 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jun 2011 17:05:27 -0000 Thanks for the reminder Julian. I've just committed a fix to trunk that I'd appreciate if you could look = at. > Might be nice if someone else would read through tar. More eyes are always better! I'd especially appreciate help improving the test suite for tar. I've put a lot of work into the test suite for libarchive, but the tar front-end has seen less effort in this area. Cheers, Tim On Jun 23, 2011, at 9:20 AM, Julian H. Stacey wrote: > FreeBSD tar has deficient error handling. I sent a fix 31 Jan 2011 > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D154407 > Please commit the fix or write & commit a better fix. >=20 > As error codes ignored, I wonder if other poor coding may lurk in tar. = =20 > Might be nice if someone else would read through tar. >=20 > ports/ : Tar allows some errors in ports pkg-list to go un-noticed. > Using make package, tar fails to see errors, fails to return error > to make, some pkg-list not checked properly & accumulate errors, > A bunch of errors will probably show up when tar is fixed, the > more the longer we do nothing. ( I can't remember which pkg-list > are broken, I've not kept note, The solution is to read tar & > commit a fix to tar ASAP) >=20 > Cheers, > Julian > --=20 > Julian Stacey, BSD Unix Linux C Sys Eng Consultants Munich = http://berklix.com > Reply below, not above; Indent with "> "; Cumulative like a play = script. > Format: Plain text. Not HTML, multipart/alternative, base64, = quoted-printable. > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to = "freebsd-hackers-unsubscribe@freebsd.org"