From owner-svn-ports-head@FreeBSD.ORG Wed Feb 5 13:40:10 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from gahrfit.gahr.ch (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C84632A7; Wed, 5 Feb 2014 13:40:07 +0000 (UTC) Date: Wed, 5 Feb 2014 14:40:04 +0100 From: Pietro Cerutti To: Max Brazhnikov Subject: Re: svn commit: r342543 - in head/devel/libqxt: . files Message-ID: <20140205134004.GF95905@gahrfit.gahr.ch> References: <201402041452.s14EqQm7008451@svn.freebsd.org> <1607567.F0A7tkxbY2@mercury.ph.man.ac.uk> <20140205094246.GE95905@gahrfit.gahr.ch> <19602658.DKafOsVslD@mercury.ph.man.ac.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4/KhLkEx1OUQso4T" Content-Disposition: inline In-Reply-To: <19602658.DKafOsVslD@mercury.ph.man.ac.uk> X-PGP-Key: fp="DA6D E106 A5B8 54B8 5DD8 6D49 ADD0 D38E A192 089E"; id="0xA192089E"; get=; get=; User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: gahr@FreeBSD.org List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Feb 2014 13:40:10 -0000 --4/KhLkEx1OUQso4T Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2014-Feb-05, 12:33, Max Brazhnikov wrote: > On Wed, 05 Feb 2014 10:42:46 +0100 Pietro Cerutti wrote: > > On 2014-Feb-04, 20:11, Max Brazhnikov wrote: > > > Hi Pietro, > >=20 > > Hi Max, > >=20 > > thanks for your valuable feedback! > >=20 > > > On Tue, 04 Feb 2014 14:52:26 +0000Tue Feb 4 14:52:26 2014 Pietro Cer= utti wrote: > > > > Author: gahr > > > > Date: Tue Feb 4 14:52:26 2014 > > > > New Revision: 342543 > > > > URL: http://svnweb.freebsd.org/changeset/ports/342543 > > > > QAT: https://qat.redports.org/buildarchive/r342543/ > > > >=20 > > > > Log: > > > > - STAGE-clean > > > > - Fix LIB_DEPENDS format > > > >=20 > > > > Modified: > > > > head/devel/libqxt/Makefile > > > > head/devel/libqxt/files/patch-src-designer_designer.pro > > > > head/devel/libqxt/pkg-plist > > > >=20 > > > > Modified: head/devel/libqxt/Makefile > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > > > --- head/devel/libqxt/Makefile Tue Feb 4 14:42:21 2014 (r342542) > > > > +++ head/devel/libqxt/Makefile Tue Feb 4 14:52:26 2014 (r342543) > > > > @@ -10,7 +10,7 @@ DISTNAME=3D v${PORTVERSION} > > > > MAINTAINER=3D gahr@FreeBSD.org > > > > COMMENT=3D Extension library for Qt > > > > =20 > > > > -LIB_DEPENDS=3D dns_sd:${PORTSDIR}/net/avahi-libdns > > > > +LIB_DEPENDS=3D libdns_sd.so:${PORTSDIR}/net/avahi-libdns > > > > BUILD_DEPENDS=3D bash:${PORTSDIR}/shells/bash > > > > =20 > > > > USE_BDB=3D 44+ > > > > @@ -21,10 +21,10 @@ USE_LDCONFIG=3D ${PREFIX}/lib/qxt > > > > =20 > > > > QT_NONSTANDARD=3D yes > > > > HAS_CONFIGURE=3D yes > > > > -CONFIGURE_ARGS=3D -prefix ${PREFIX} \ > > > > - -libdir ${PREFIX}/lib/qxt \ > > > > +CONFIGURE_ARGS=3D -prefix ${STAGEDIR}${PREFIX} \ > > >=20 > > > In qmake world the STAGEDIR is called INSTALL_ROOT. Perhaps you could= avoid > > > this and related hacks, if you'd set DESTDIRNAME=3DINSTALL_ROOT. > >=20 > > It is not really clear to me how you think I should fix this. Could you > > please be more precise please? >=20 > Just add 'DESTDIRNAME=3D INSTALL_ROOT' to Makefile :) >=20 > See the patch with all my suggestions and some other improvements: > http://people.freebsd.org/~makc/patches/libqxt.diff Thanks, much appreciated! However, this fails with port test: http://people.freebsd.org/~gahr/libqxt.log --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp --4/KhLkEx1OUQso4T Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQJ8BAEBCgBmBQJS8j8vXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQTZERTEwNkE1Qjg1NEI4NUREODZENDlB REQwRDM4RUExOTIwODlFAAoJEK3Q046hkgieOQYP/j256cvfs5H961s91a1Uki+Y fhpfTYFPQHo9V4bVzqDKvtuuQ2Cm9lPHQXaO3zikH80E1oDU0nHO/H2K7fb5Nqjk Tn1sbab9lqsrFKbh5TTGS7tHo5nV2v6vxDs2SaqQXCkpXGwKaxd+7Z20kfntsUsa 6XAwgYousZ3vcIXp/qFiLmAClfd2EX83RNz++sMqLbpc4odWkK8sV1pK6KFm6iJ2 87Q6ubQslY4Js8DB49MAT7T0dHqzbtZN7muiTryLkst8wOKR0fDByk31Q4zqHeRj 7PEwwSVnlgtDKJujmiHdsI7XbvF4Up/WtsjIEkntFXbq5GfkOV433AS5j38Lic0d S/OSPEEM/ZQfjnBtBB+gtdzNNUd9wbbmls05Hqv7WIxdOemjca9OWLxPtvuPB8+M bEtjgoyAZFi/S+F2YjVZ2z79N3go5u4uFp0nlEvFnehnihyXpemCsCT5e82D7edL b41klw40yLwJLpbuHzz1WLsudrvoVdmuX9lSfc/0ksRnMOE0F/LFt72s0pfvejWL 1N5q0LH7pXqWhDhPzcucUPTWuig1yCdPD28UN2N6D8bBSYIfIZ2jcdwX69LIjwT3 PT97prmALyREO/AknmkuLq5jYjVITFnsaafjUlEQPXrynreMxiWgour9vwCc+SuC PWxjAV2eYByOKXh8eDPL =2Nql -----END PGP SIGNATURE----- --4/KhLkEx1OUQso4T--