From owner-freebsd-ppc@FreeBSD.ORG  Sat Jul  7 14:20:13 2012
Return-Path: <owner-freebsd-ppc@FreeBSD.ORG>
Delivered-To: freebsd-ppc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C60FB10657A3;
	Sat,  7 Jul 2012 14:20:13 +0000 (UTC)
	(envelope-from chmeeedalf@gmail.com)
Received: from mail-qa0-f47.google.com (mail-qa0-f47.google.com
	[209.85.216.47])
	by mx1.freebsd.org (Postfix) with ESMTP id 63F668FC16;
	Sat,  7 Jul 2012 14:20:13 +0000 (UTC)
Received: by qabg1 with SMTP id g1so900854qab.13
	for <multiple recipients>; Sat, 07 Jul 2012 07:20:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=date:from:to:cc:subject:message-id:x-mailer:mime-version
	:content-type; bh=VcJGeqLllEyUlkggXQOmw2RNN3FIsZJRRtN8aVFBppI=;
	b=YCErr+KRKE0/6HUhSigNmDiECIErizJNrld16vgp7KLPS5MnMLQT+1X9bWNWFImuBW
	9y7ZpQsGsIhw8YZMp4tVVuQnjk1stRRLwjQCth7DwU6KU8wxsTygNRUE41OsukIE9qPl
	eeaE16Txv2R7A2Dfg2e6YLC+qaCWTo6n+McAHp3u06hcxVQTscnEDMOl7zeQ0M7ZWEJM
	YbNoW8frHoA2OX+nwGwdQryxGeJv8sUkEW7TLILCKj5siSXCljUMR0ndxenf3hflimHB
	Hhy/wfRd1dcmswKjf377fgqNcSJNF6rVeUnpmwlnTk6QMdDQHgB5pWYkwpcvmPn2+EGa
	GxWA==
Received: by 10.229.135.134 with SMTP id n6mr12322993qct.140.1341670807048;
	Sat, 07 Jul 2012 07:20:07 -0700 (PDT)
Received: from narn.knownspace (pool-71-163-84-156.washdc.fios.verizon.net.
	[71.163.84.156])
	by mx.google.com with ESMTPS id cz12sm54276037qab.5.2012.07.07.07.20.06
	(version=TLSv1/SSLv3 cipher=OTHER);
	Sat, 07 Jul 2012 07:20:06 -0700 (PDT)
Date: Sat, 7 Jul 2012 10:20:04 -0400
From: Justin Hibbits <chmeeedalf@gmail.com>
To: freebsd-ppc@freebsd.org
Message-ID: <20120707102004.3e874201@narn.knownspace>
X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; powerpc-portbld-freebsd10.0)
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="MP_/=yp8b+xTANc5VsOBTVQLI=Y"
Cc: alc@freebsd.org
Subject: Panic with latest pmap lock changes.
X-BeenThere: freebsd-ppc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the PowerPC <freebsd-ppc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ppc>,
	<mailto:freebsd-ppc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ppc>
List-Post: <mailto:freebsd-ppc@freebsd.org>
List-Help: <mailto:freebsd-ppc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ppc>,
	<mailto:freebsd-ppc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Jul 2012 14:20:13 -0000

--MP_/=yp8b+xTANc5VsOBTVQLI=Y
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Looks like I spoke too soon about the pmap lock changes working on my
G4.  After about 24 hours of uptime, it panicked with the following:

_rw_wlock_hard: recursing but non-recursive rw pmap pv global
@ /home/chmeee/freebsd/src/sys/powerpc/aim/mmu_oea.c:2301

I think the attached patch should fix it (Untested, except for
compiling).

- Justin
--MP_/=yp8b+xTANc5VsOBTVQLI=Y
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=mmu_oea.diff

Index: sys/powerpc/aim/mmu_oea.c
===================================================================
--- sys/powerpc/aim/mmu_oea.c	(revision 238165)
+++ sys/powerpc/aim/mmu_oea.c	(working copy)
@@ -874,7 +874,7 @@
  	/*
 	 * Initialize the global pv list lock.
 	 */
-	rw_init(&pvh_global_lock, "pmap pv global");
+	rw_init_flags(&pvh_global_lock, "pmap pv global", RW_RECURSE);
 
 	/*
 	 * Set up the Open Firmware mappings

--MP_/=yp8b+xTANc5VsOBTVQLI=Y--