From owner-svn-src-all@FreeBSD.ORG Thu Jan 22 09:23:03 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 55391B49 for ; Thu, 22 Jan 2015 09:23:03 +0000 (UTC) Received: from mailrelay10.public.one.com (mailrelay10.public.one.com [195.47.247.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C3CA035D for ; Thu, 22 Jan 2015 09:23:01 +0000 (UTC) X-HalOne-Cookie: 9f6213b6b59468badff61996346a9a1a4a30b6f8 X-HalOne-ID: 18b6d401-a218-11e4-9705-b82a72d06996 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cederstrand.dk; s=20140924; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to: references; bh=O3M0lAgommefxFPD/U0U/ZccpUy/AwJnKIlJb1V+bSA=; b=nu5lq11VemVT2Lk+dQ96OMUlCPkjpQV9z1LDpkboABS30y986RIualNF3za3YS1la+NvnXuh1NUtj vDWbSAdUoYHoYxuKBJBEKWCR72DYp0C16IEnNtvAFeHNlAU2XP/A/JyKvwBImsr/zHPbR5RCqSmjSG kFm19XqvBXIxwaXU= Received: from [192.168.1.58] (unknown [217.157.7.221]) by smtpfilter3.public.one.com (Halon Mail Gateway) with ESMTPSA; Thu, 22 Jan 2015 09:21:50 +0000 (GMT) Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: multipart/signed; boundary="Apple-Mail=_5559BE3C-DD53-4BCD-B541-DEBD07465DA9"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b4 From: Erik Cederstrand In-Reply-To: <54C0B75B.9070305@selasky.org> Date: Thu, 22 Jan 2015 10:21:50 +0100 Message-Id: References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <54BDD9E1.6090505@selasky.org> <20150120075126.GA42409@kib.kiev.ua> <54BE0AAA.4050104@selasky.org> <20150120090057.GD42409@kib.kiev.ua> <54BE21F0.6010602@selasky.org> <7C692107-51CF-4DFA-BD6C-623D56893150@bsdimp.com> <54C0A352.8090701@selasky.org> <20150122081023.GT42409@kib.kiev.ua> <54C0B75B.9070305@selasky.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.1993) Cc: Kostik Belousov , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2015 09:23:03 -0000 --Apple-Mail=_5559BE3C-DD53-4BCD-B541-DEBD07465DA9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > Den 22/01/2015 kl. 09.39 skrev Hans Petter Selasky : >=20 > Are you saying that pieces of code that runs completely unlocked using = "volatile" as only synchronization mechanism is better than what I would = call a temporary and hopefully short TCP stack performance loss? >=20 > I don't understand? How frequently do you reboot your boxes? Maybe one = every day? And you don't care? Hans, I'm just a spectator here, but please do yourself and the project = a favor and back out your change, go back to the Phabricator review once = more and let the review process roll until everyone is satisfied. Although it's not very evident in this thread, I'm sure everyone = actually appreciates your work. I also acknowledge that it's frustrating = to back out a commit that you have spent a lot of effort on, and which = fixes actual bugs. It's also frustrating to get insufficient feedback on a code review, but = you certainly got people's attention now. Now you need to trust that the = people voicing concerns will step up and provide constructive feedback = in Phabricator, so this can be committed in a timely manner, in a = quality that we expect from FreeBSD. Kind regards, Erik --Apple-Mail=_5559BE3C-DD53-4BCD-B541-DEBD07465DA9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUwMEvAAoJEFWwJk18WUOGNhoP/24vIV3iwuoK0+rxRI4XgI/W 5UrPI9CrUPKihaYu9TGnd1uyfXFNnMjW1d/p/8KGET8jowLG+8Q/WYnxKZfB1lQ2 yW0PRFNwH9xNYdPiW5tMQOW8S1mBaxW6rl+BjZB8VxM3h2BM9I+eM4HENbSzC1Un nvW8P8q6jUjpDiWVJSiUGuwXP//fnVAQmL/MeecFqeJvUqVgxTWixcucBEnzBYnn cButKWRBTK8B87y7eFMSCmbEhxe0bLmn1mBKpbkzEVQCFZsLZekPqoCT2GyDOA8k B/i1qlGuMZeOWLnSg2gshCCRYYOpgwVSzqegYurz4jVvR4QGufd7c1kgc+3DxX45 jnWEMprh6XlLajgrJIUcV4unWtNAlFB8WlE3o8UR+ufHqsFu6Fmy/GPqMzy3tTfJ sRk6k+5SkVHnx+8UBEncNzYIrbHZj7f0Z0tWfg3wiLNLop2BVLBCAs6+yJnGL2Ef y17J/Kidvj9+P51Grx89KzHKt1UFi4F/1uFeYHNFA27d+1qe5LQMDI/8RfV/xiYL 7gvfBCURGPNJMTSqZbj7NTdYiQ7JoCITRtKxXHN/9XMj4+NqmWnR3O97C1Lrbu4S B5vHdQNGluS6buyfBTK3pba5oUvBxqfsK39sOmTU7YVZ9YZuTOcMhg0QPKMrd6l0 R5ucUgtZ39gk09O6bqEA =j32Y -----END PGP SIGNATURE----- --Apple-Mail=_5559BE3C-DD53-4BCD-B541-DEBD07465DA9--