From owner-freebsd-current@FreeBSD.ORG  Mon Sep 28 23:06:52 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C35DE1065670
	for <current@freebsd.org>; Mon, 28 Sep 2009 23:06:52 +0000 (UTC)
	(envelope-from ken@mthelicon.com)
Received: from hercules.mthelicon.com (hercules.mthelicon.com
	[IPv6:2001:49f0:2023::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 865FB8FC12
	for <current@freebsd.org>; Mon, 28 Sep 2009 23:06:52 +0000 (UTC)
Received: from feathers.peganest.com (feathers.peganest.com [78.33.110.3])
	(authenticated bits=0)
	by hercules.mthelicon.com (8.14.3/8.14.3) with ESMTP id n8SN6jqx090974
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO)
	for <current@freebsd.org>; Mon, 28 Sep 2009 23:06:46 GMT
	(envelope-from ken@mthelicon.com)
From: Pegasus Mc Cleaft <ken@mthelicon.com>
Organization: Feathers
To: FreeBSD current mailing list <current@freebsd.org>
Date: Tue, 29 Sep 2009 00:06:43 +0100
User-Agent: KMail/1.12.1 (FreeBSD/9.0-CURRENT; KDE/4.3.1; amd64; ; )
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <200909290006.44164.ken@mthelicon.com>
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on
	hercules.mthelicon.com
Cc: 
Subject: Typo in rc.d/netoptions?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Sep 2009 23:06:52 -0000

Hello Current, 

	I was wondering if there is a typo in rc.d/netoptions that has inverted logic 
for tcp_extensions and missing the banner before changing the ipv4 to 6 
mapping? I think I have patched it, but would like a second opinion.

Peg

--- /usr/src/etc/rc.d/netoptions        2009-09-13 00:02:18.984185765 +0100
+++ /etc/rc.d/netoptions        2009-09-29 00:02:46.210831591 +0100
@@ -32,7 +32,7 @@
                ${SYSCTL_W} net.inet.udp.log_in_vain="${log_in_vain}" 
>/dev/null
        fi

-       if checkyesno tcp_extensions; then
+       if ! checkyesno tcp_extensions; then
                netoptions_init
                echo -n ' rfc1323 extensions=NO'
                ${SYSCTL_W} net.inet.tcp.rfc1323=0 >/dev/null
@@ -69,6 +69,7 @@
        if checkyesno ipv6_ipv4mapping; then
                ${SYSCTL_W} net.inet6.ip6.v6only=0 >/dev/null
        else
+               netoptions_init
                echo -n " no-ipv4-mapped-ipv6"
                ${SYSCTL_W} net.inet6.ip6.v6only=1 >/dev/null
        fi