From owner-freebsd-current@FreeBSD.ORG Mon Sep 22 19:22:04 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EE1F1D1A; Mon, 22 Sep 2014 19:22:04 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C5BE1A9E; Mon, 22 Sep 2014 19:22:04 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net [173.70.85.31]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id E3302B98E; Mon, 22 Sep 2014 15:22:02 -0400 (EDT) From: John Baldwin To: Warner Losh Subject: Re: [PATCH] Various fixes to wl(4) Date: Mon, 22 Sep 2014 15:20:05 -0400 Message-ID: <2930763.7FbKMgYveJ@ralph.baldwin.cx> User-Agent: KMail/4.10.5 (FreeBSD/10.0-STABLE; KDE/4.10.5; amd64; ; ) In-Reply-To: <4D1FD834-2861-4D16-9ABF-21B8B07561F8@bsdimp.com> References: <1815820.OytfPhNq3X@ralph.baldwin.cx> <4D1FD834-2861-4D16-9ABF-21B8B07561F8@bsdimp.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 22 Sep 2014 15:22:03 -0400 (EDT) Cc: freebsd-current@freebsd.org, imp@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2014 19:22:05 -0000 On Friday, September 19, 2014 03:47:16 PM Warner Losh wrote: > I got rid of my pre-802.11 WaveLAN cards about 8 years go after not h= aving > them in a system at all for 8 years. And they were about 4 years obso= lete > when I took them out of service=E2=80=A6 I=E2=80=99m not even sure I = have a machine with an > ISA slot to test the card, even if I still had it. >=20 > Sorry I can=E2=80=99t help more :) If no one tests them then I will happily toss the driver into the dustb= in,=20 just giving folks a chance to test patches before I do so. (I'm secret= ly=20 hoping I can purge several old drivers during the current round of time= out()=20 purging.) > Warner >=20 > On Sep 19, 2014, at 2:07 PM, John Baldwin wrote: > > This patch fixes various issues in wl(4) including: > >=20 > > - Use bus_space instead of inb/outb. > > - Use device_printf() and if_printf() > > - Use callout(9) instead of timeout(9) > > - Don't hold the driver lock across sleeping actions like > >=20 > > bus_teardown_intr(), subyte(), etc. > >=20 > > - Don't recurse on the driver lock. > >=20 > > The patch is against HEAD but probably applies to 9 and 10 as well.= > >=20 > > http://people.freebsd.org/~jhb/patches/wl_cleanup.patch --=20 John Baldwin