From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 7 20:40:02 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 82A621065688 for ; Sun, 7 Sep 2008 20:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 671558FC1C for ; Sun, 7 Sep 2008 20:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m87Ke2sM066886 for ; Sun, 7 Sep 2008 20:40:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m87Ke2Gf066885; Sun, 7 Sep 2008 20:40:02 GMT (envelope-from gnats) Resent-Date: Sun, 7 Sep 2008 20:40:02 GMT Resent-Message-Id: <200809072040.m87Ke2Gf066885@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Joost Bekkers Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E8E001065686 for ; Sun, 7 Sep 2008 20:35:23 +0000 (UTC) (envelope-from joost@jodocus.org) Received: from viefep13-int.chello.at (viefep18-int.chello.at [213.46.255.22]) by mx1.freebsd.org (Postfix) with ESMTP id 5B6248FC19 for ; Sun, 7 Sep 2008 20:35:22 +0000 (UTC) (envelope-from joost@jodocus.org) Received: from edge01.upc.biz ([192.168.13.236]) by viefep15-int.chello.at (InterMail vM.7.08.02.00 201-2186-121-20061213) with ESMTP id <20080907201926.UZNW13197.viefep15-int.chello.at@edge01.upc.biz> for ; Sun, 7 Sep 2008 22:19:26 +0200 Received: from bps.jodocus.org ([62.194.47.110]) by edge01.upc.biz with edge01 id BwKD1a00r2NeSae01wKSAP; Sun, 07 Sep 2008 22:19:26 +0200 Received: from jodocus.org (localhost [127.0.0.1]) by bps.jodocus.org (8.14.2/8.14.2) with ESMTP id m87KJDHS082892 for ; Sun, 7 Sep 2008 22:19:13 +0200 (CEST) (envelope-from joost@jodocus.org) Received: (from joost@localhost) by jodocus.org (8.14.2/8.14.2/Submit) id m87KJDl8082891; Sun, 7 Sep 2008 22:19:13 +0200 (CEST) (envelope-from joost) Message-Id: <200809072019.m87KJDl8082891@jodocus.org> Date: Sun, 7 Sep 2008 22:19:13 +0200 (CEST) From: Joost Bekkers To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/127194: [PATCH] arpa/telnet.h: TELOPT(x) returns wrong result / segfaults X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Joost Bekkers List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Sep 2008 20:40:02 -0000 >Number: 127194 >Category: bin >Synopsis: [PATCH] arpa/telnet.h: TELOPT(x) returns wrong result / segfaults >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 07 20:40:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Joost Bekkers >Release: FreeBSD 7.0-RELEASE-p4 amd64 >Organization: >Environment: System: FreeBSD bps.jodocus.org 7.0-RELEASE-p4 FreeBSD 7.0-RELEASE-p4 #3: Wed Sep 3 23:33:23 CEST 2008 joost@bps.jodocus.org:/usr/src/sys/amd64/compile/bps amd64 >Description: The telnet options added to src/contrib/telnet/arpa/telnet.h in rev 1.9 (==RELENG_5_2_0_RELEASE==HEAD) were discontinuous, but names were added to telopts[] without the corresponding gaps. This can cause TELOPT to return pointers outside of telopts[] even though TELOPT_OK returns 'true'. >How-To-Repeat: #include #define TELOPTS #include int main(int argc,char *argv[]) { unsigned int opt; opt=TELOPT_KERMIT; if (TELOPT_OK(opt)) printf("Option name:%s\n",TELOPT(opt)); else printf("Unknown option %d\n",opt); return 0; } depending on your luck, this either tells you the option is "(null)" or segfaults. >Fix: --- telnet.h.org 2008-09-07 21:45:53.000000000 +0200 +++ telnet.h 2008-09-07 22:12:19.000000000 +0200 @@ -140,8 +140,8 @@ "TACACS UID", "OUTPUT MARKING", "TTYLOC", "3270 REGIME", "X.3 PAD", "NAWS", "TSPEED", "LFLOW", "LINEMODE", "XDISPLOC", "OLD-ENVIRON", "AUTHENTICATION", - "ENCRYPT", "NEW-ENVIRON", "TN3270E", "CHARSET", "COM-PORT", - "KERMIT", + "ENCRYPT", "NEW-ENVIRON", "TN3270E", "XAUTH", "CHARSET", + "RSP", "COM-PORT", "SLE", "STARTTLS", "KERMIT", 0 }; #define TELOPT_FIRST TELOPT_BINARY >Release-Note: >Audit-Trail: >Unformatted: