From owner-svn-src-stable-8@FreeBSD.ORG Tue Apr 6 05:41:49 2010 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BBA9B106566C; Tue, 6 Apr 2010 05:41:49 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-bw0-f216.google.com (mail-bw0-f216.google.com [209.85.218.216]) by mx1.freebsd.org (Postfix) with ESMTP id 8B1F38FC23; Tue, 6 Apr 2010 05:41:45 +0000 (UTC) Received: by bwz8 with SMTP id 8so3493754bwz.3 for ; Mon, 05 Apr 2010 22:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type; bh=wLcajAg9Qzw/OEB7BXrOBeWE0LQgEwX1mE6GdsVmKkg=; b=csLRMXz2aJYjP6gPbDRjoJT+QuoDinSiRthVlwG6T2UZyg5/kziJvWOH4hraq6+XwQ vKf9NmxdlaJa35rlaOSBzXTc4cSXRGYfFfHu4zm6jReB5qTHcATsqSuzomnl0WomnpSO HNMVZABnfT5LRtXZZs/ov0LHqXL0Ruxy9utgQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=J1KAXyT6CIEOswomahzQKac3wNOSxi8KzTmLAIACCBRPnS1MY7bZgNWOqAR6VpVQNm e6s1q0Tp27m98/kNHv5+brasj4qJ3lUZl6K0gw9BXODXrwE5suB2jVzrkjzIYFI6hrBf SLv/nSLDBnDVr2RbtMEmHEzcxFJmxuEXr+/uo= MIME-Version: 1.0 Received: by 10.204.59.6 with HTTP; Mon, 5 Apr 2010 22:41:44 -0700 (PDT) In-Reply-To: <20100406041023.GA4829@zibbi.meraka.csir.co.za> References: <201004052143.o35LhNFt052897@svn.freebsd.org> <20100406041023.GA4829@zibbi.meraka.csir.co.za> Date: Mon, 5 Apr 2010 22:41:44 -0700 Received: by 10.204.2.196 with SMTP id 4mr726042bkk.121.1270532504548; Mon, 05 Apr 2010 22:41:44 -0700 (PDT) Message-ID: From: Jack Vogel To: John Hay Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Jack F Vogel , svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r206215 - in stable/8/sys/modules: em ixgbe X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2010 05:41:49 -0000 Its been without the if_ prefix for a couple years :) However if enough people's sense of propriety is offended I suppose I could change it. As for adding it to the modules/Makefile, the main reason it was not was that the users of 10G were very small, but that is changing so I suppose its time to add it. Will take care of that soon. Jack On Mon, Apr 5, 2010 at 9:10 PM, John Hay wrote: > Hi Jack, > > On Mon, Apr 05, 2010 at 09:43:23PM +0000, Jack F Vogel wrote: > > Author: jfv > > Date: Mon Apr 5 21:43:22 2010 > > New Revision: 206215 > > URL: http://svn.freebsd.org/changeset/base/206215 > > > > Log: > > Add missing module Makefile for ixgbe and em MFCs > > > > Modified: > > stable/8/sys/modules/em/Makefile > > stable/8/sys/modules/ixgbe/Makefile > > I notice that in ixgbe/Makefile KMOD is ixgbe. Should it not be if_ixgbe? > Most other network drivers have if_ in front. It is not because of this > commit because it is like that in current too. I also see ixgbe is not > listed in modules/Makefile, so it will not be built automatically with > the rest. Any reason not to add it? > > Thanks > > John > -- > John Hay -- jhay@meraka.csir.co.za / jhay@FreeBSD.org >