From owner-svn-ports-head@freebsd.org  Sat Oct 10 14:44:37 2015
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86456A10E32;
 Sat, 10 Oct 2015 14:44:37 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 72F5869D;
 Sat, 10 Oct 2015 14:44:37 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 162921064; Sat, 10 Oct 2015 14:44:36 +0000 (UTC)
Date: Sat, 10 Oct 2015 14:44:36 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: marino@freebsd.org
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r398971 - in head/audio/musescore: . files
Message-ID: <20151010144435.GA90609@FreeBSD.org>
References: <201510100544.t9A5iZA2064835@repo.freebsd.org>
 <20151010070827.GA93698@FreeBSD.org> <5618BFB3.2020905@marino.st>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5618BFB3.2020905@marino.st>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Oct 2015 14:44:37 -0000

On Sat, Oct 10, 2015 at 09:35:15AM +0200, John Marino wrote:
> On 10/10/2015 9:08 AM, Alexey Dokuchaev wrote:
> > On Sat, Oct 10, 2015 at 05:44:35AM +0000, John Marino wrote:
> >> New Revision: 398971
> >> URL: https://svnweb.freebsd.org/changeset/ports/398971
> >>
> >> [...]
> >> +	@${REINPLACE_CMD} -e \
> >> +		's|<errno.h>|<cerrno>| ; \
> >> +		 s|<limits.h>|<climits>| ; \
> >> +		 s|<math.h>|<cmath>| ; \
> >> +		 s|<stdio.h>|<cstdio>|' ${WRKSRC}/all.h
> > 
> > I think these foo.h are missing escaping of the dot (should be foo\.h), no?
> 
> Yes, but adding a slash doesn't change the result.  It's a more correct
> matching, but the current version is good enough (e.g. <errno.h> doesn't
> match more than <errno\.h>) .  In any case, it passed a build test.

It's certainly works and is good enough, but seeing this mistake made
often I'd wanted to point it out for educational purposes given chance.

./danfe