From owner-freebsd-mips@FreeBSD.ORG  Mon May 17 21:04:42 2010
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EAD1E1065678;
	Mon, 17 May 2010 21:04:42 +0000 (UTC)
	(envelope-from rrs@lakerest.net)
Received: from lakerest.net (unknown [IPv6:2001:240:585:2:213:d4ff:fef3:2d8d])
	by mx1.freebsd.org (Postfix) with ESMTP id 78FE98FC18;
	Mon, 17 May 2010 21:04:42 +0000 (UTC)
Received: from mobile-166-129-180-182.mycingular.net
	(mobile-166-129-180-182.mycingular.net [166.129.180.182] (may
	be forged)) (authenticated bits=0)
	by lakerest.net (8.14.3/8.14.3) with ESMTP id o4HL46PX042786
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT);
	Mon, 17 May 2010 17:04:40 -0400 (EDT)
	(envelope-from rrs@lakerest.net)
Message-Id: <728CDFF3-7EB8-4618-8805-EFD991ADCBC8@lakerest.net>
From: Randall Stewart <rrs@lakerest.net>
To: "C. Jayachandran" <c.jayachandran@gmail.com>
In-Reply-To: <AANLkTim5HbGok2z8ZImgCvpBbMSWVx-G34YBTo9dPEUE@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v936)
Date: Mon, 17 May 2010 14:04:24 -0700
References: <AANLkTikjF2SUa5GomVRtus176hjKyUyPAeDF-p1kwCcO@mail.gmail.com>
	<AANLkTin1CmrTmuwChVnwBaSRsnQO8mcwE5P9fXBtPTvp@mail.gmail.com>
	<AANLkTim5HbGok2z8ZImgCvpBbMSWVx-G34YBTo9dPEUE@mail.gmail.com>
X-Mailer: Apple Mail (2.936)
Cc: freebsd-mips@freebsd.org
Subject: Re: Minor fixup for the MIPS SMP platform code.
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 May 2010 21:04:43 -0000

JC:

Give me a few hours and I will get it in.. need to finish
my work day first ;-0

R
On May 17, 2010, at 10:38 AM, C. Jayachandran wrote:

> On Mon, May 17, 2010 at 9:08 PM, Neel Natu <neelnatu@gmail.com> wrote:
> Hi JC,
>
> Your patch looks good. Thanks for cleaning up the platform-specific
> code from mp_machdep.c.
>
> There are a couple of style things you might want to take care of:
>
> 1. In hwfunc.h there is an extra space after the '*' in the
> declaration of platform_smp_topo()
>
> 2. In platform_smp_topo() for XLR:
>    - Values in return statements should be enclosed in parantheses.
>    - space around binary operator '/'
>
>
> Looks like I've been a bit sloppy here, updated patch attached, with  
> all the comments so far addressed.
>
> Thanks,
> JC.
>
>
> best
> Neel
>
> On Mon, May 17, 2010 at 7:33 AM, C. Jayachandran
> <c.jayachandran@gmail.com> wrote:
> > The attached patch (also at
> > http://sites.google.com/site/cjayachandran/files) has two changes:
> > - moves the intr masking code to platform_init_ap, so that we can  
> avoid the
> > #ifdef for XLR
> > - adds a platform_smp_topo() function so that platforms can define  
> their
> > topology
> >
> > I've also attempted to fixup sys/mips/sibyte to reflect these  
> changes, but
> > it might need further work.
> > sys/mips/cavium also might need similar changes for SMP.
> >
> > Please review and apply if the changes are okay.
> >
> > Thanks,
> > JC.
> >
> >
>
>
>
> -- 
> C. Jayachandran    c.jayachandran@gmail.com
> <mips-smp-fixup.patch>

------------------------------
Randall Stewart
803-317-4952 (cell)
803-345-0391(direct)