From owner-cvs-src@FreeBSD.ORG Fri Aug 3 07:33:56 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C63F316A41A; Fri, 3 Aug 2007 07:33:56 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.freebsd.org (Postfix) with ESMTP id 420C313C4A7; Fri, 3 Aug 2007 07:33:56 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.14.1/8.14.1) with ESMTP id l737Xf9D096159; Fri, 3 Aug 2007 11:33:41 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Fri, 3 Aug 2007 11:33:41 +0400 (MSD) From: Dmitry Morozovsky To: d@delphij.net In-Reply-To: <46B2CB2C.7030504@delphij.net> Message-ID: <20070803113300.W80820@woozle.rinet.ru> References: <200708030624.l736OV3b043646@repoman.freebsd.org> <46B2CB2C.7030504@delphij.net> X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (woozle.rinet.ru [0.0.0.0]); Fri, 03 Aug 2007 11:33:41 +0400 (MSD) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Xin LI , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/fs/tmpfs tmpfs.h tmpfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2007 07:33:56 -0000 Dear Xin, On Fri, 3 Aug 2007, LI Xin wrote: LX> > Log: LX> > MFp4 - Refine locking to eliminate some potential race/panics: LX> > LX> > - Copy before testing a pointer. This closes a race window. LX> > - Use msleep with the node interlock instead of tsleep. LX> > - Do proper locking around access to tn_vpstate. LX> > - Assert vnode VOP lock for dir_{atta,de}tach to capture LX> > inconsistent locking. LX> > LX> > Suggested by: kib LX> > Submitted by: delphij LX> > Reviewed by: Howard Su LX> > Approved by: re (tmpfs blanket) LX> LX> Should have mentioned that this is done in response of pho@'s stress LX> test. Thanks goes to him for all these hard work! Should it fix panics I reported to you during last couple of days? Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------