From owner-freebsd-ports@FreeBSD.ORG Thu Jul 12 04:38:57 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDA1A106564A; Thu, 12 Jul 2012 04:38:57 +0000 (UTC) (envelope-from henry.hu.sh@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 40EF98FC0A; Thu, 12 Jul 2012 04:38:57 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so3446039pbb.13 for ; Wed, 11 Jul 2012 21:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=ZohFqEUtPlo/k5T1WHcu2hYjfBFlitrXtoeLzwzhpmw=; b=fXYJdzQpqeF4CcEeQtjH5YAoxsvQtp1hTgUKYYCE2gYO3VG3AlqwLfmvTGEPY+m/I7 bRHBm6mck+0u35kDauWOTRTNcjaKEBkiZM7dj5L9NLP0XI7Xtydos3hYgeJqqDRDyyGc CJ72rdbRyVBl5ThViAwTL+KINvE3GiI6t0yo+3VaFDVfiz55KE+by2W4aJB64Znv08Ya UGI2wB71wGG4iiclbEc+XupsM4yUJe1udQmWfzg3dfMpTt6RJ45lBuQanRVp5w8lf3NW BIuOW8G56QAz3kEUUlXv0Ti1O6dJF8pTalGKm/fZm/aKTMycnTea8CgBRwFjZ4YdawgB /NDQ== Received: by 10.68.138.166 with SMTP id qr6mr2094281pbb.43.1342067936897; Wed, 11 Jul 2012 21:38:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.213.197 with HTTP; Wed, 11 Jul 2012 21:38:36 -0700 (PDT) In-Reply-To: References: <201207042153.q64Lrajj048759@repoman.freebsd.org> <4FF4BDFC.7070604@FreeBSD.org> <85zFQmwqygMzE5IoVEZOBb55NHc@h+Kmx6xuhLPDxlAxgYCP+NijPgY> <4FF95786.2070905@FreeBSD.org> <20120709081324.GB13540@MacBook-Eygene-Ryabinkin.local> <4FFBD95F.6010209@FreeBSD.org> From: Henry Hu Date: Thu, 12 Jul 2012 00:38:36 -0400 Message-ID: To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Cc: ports@freebsd.org, Michael Scheidell , Eygene Ryabinkin Subject: Re: cvs commit: ports/x11/slim Makefile pkg-plist ports/x11/slim/files pam.conf slim.sh.in X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2012 04:38:57 -0000 Oh I'm sorry. After grabbing cmake 2.8.7, I found that Xmu is still detected in find_package(GLUT). We need a build dependency on cmake 2.8.8...... On Thu, Jul 12, 2012 at 12:26 AM, Henry Hu wrote: > I'm testing the patch. > > First, I failed to build, and the reason is that my cmake is 2.8.3 > which is too old. > According to http://www.cmake.org/pipermail/cmake-commits/2012-February/012056.html, > it seems like that after cmake 2.8.7, find_package(X11) would define > X11_Xmu_LIB, but before that, it is defined as GLUT_Xmu_LIBRARY with > find_package(GLUT). Do we need to add a build dependency that this > depends on cmake >= 2.8.7? > > It seems like that there is no reference to glut anymore. Its usage > was only to find Xmu. So I think that we should remove USE_GL=glut. > > For the png problem, I think that we can use png_jmpbuf for any libpng >>= 1.2.5? It seems to be exist at least from libpng 1.2.5 > (http://www.libpng.org/pub/png/libpng-1.2.5-manual.html) so it's safe to use it? > According to http://old.nabble.com/png_jmpbuf%28%29-in-libpng-1.4-td30966838.html, > someone has problem with png_jmpbuf with libpng 1.4, but it seems like > that this is not related. > > > On Tue, Jul 10, 2012 at 3:27 AM, Doug Barton wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA256 >> >> On 07/09/2012 01:13, Eygene Ryabinkin wrote: >>> This very error should be fixed by the patch >> >> Yes, I'm an idiot. :) I successfully applied your patch and forgot to >> move the new patch- file into files/. Once I fixed the PEBKAC it worked >> as expected on 10-current amd64, and 8-stable i386. >> >> Henry, if you'd like me to apply the patch just let me know. Eygene, >> thanks for doing this. >> >> Doug >> >> - -- >> >> Change is hard. >> >> >> >> -----BEGIN PGP SIGNATURE----- >> Version: GnuPG v2.0.19 (FreeBSD) >> >> iQEcBAEBCAAGBQJP+9lfAAoJEFzGhvEaGryEds8H/jVudAimsgQEgJZ1EGWCN7mX >> xsjam23cBz5hCAf5ay4cmDkyUbdfSeYJHTQ+WmjuMRKaoKBoyMvKSAbVcvKfOiNr >> iOoFWT82D/fXWNW+X/Ny4sqv16FNpP2hQsiEa0E5luPU9bA52wSq6kGU9EiQ+VY6 >> JrxwHV8/7MfzaX+g6fRkhwphRYI9bmzK0+evvtMtxEq9dCZTtFcMmGFSwy4EAzT3 >> 3mbMYjeWlIsCko+Y/GjtXGlopxiStbMUU32B+O1oKrvtzHJ2Srgi2vZ/B4XVXPSB >> W28ANO0AZbqzIUcZvaechXjjcb0mlNKsRnWjlDC4ysheGH6XRjLCEgFH0MZed0I= >> =nNUS >> -----END PGP SIGNATURE----- > > > > -- > Cheers, > Henry -- Cheers, Henry