From owner-cvs-src@FreeBSD.ORG  Tue Nov 15 12:43:51 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A4D5B16A421;
	Tue, 15 Nov 2005 12:43:51 +0000 (GMT)
	(envelope-from stefan@fafoe.narf.at)
Received: from viefep18-int.chello.at (viefep18-int.chello.at [213.46.255.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 70FFE43D81;
	Tue, 15 Nov 2005 12:43:36 +0000 (GMT)
	(envelope-from stefan@fafoe.narf.at)
Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep18-int.chello.at
	(InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id
	<20051115124335.QMHO5342.viefep18-int.chello.at@wombat.fafoe.narf.at>;
	Tue, 15 Nov 2005 13:43:35 +0100
Received: by wombat.fafoe.narf.at (Postfix, from userid 1001)
	id C5C6B3A8; Tue, 15 Nov 2005 13:43:33 +0100 (CET)
Date: Tue, 15 Nov 2005 13:43:33 +0100
From: Stefan Farfeleder <stefanf@FreeBSD.org>
To: Ariff Abdullah <ariff@FreeBSD.org>
Message-ID: <20051115124331.GD9996@wombat.fafoe.narf.at>
References: <200511150419.jAF4JRUp080869@repoman.freebsd.org>
	<20051115105128.a5dd001i0ckock0s@netchild.homeip.net>
	<20051115095801.M61850@fledge.watson.org>
	<20051115202306.4cf2dcf2.ariff@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051115202306.4cf2dcf2.ariff@FreeBSD.org>
User-Agent: Mutt/1.5.11
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/sound/pcm channel.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Nov 2005 12:43:51 -0000

On Tue, Nov 15, 2005 at 08:23:06PM +0800, Ariff Abdullah wrote:
> On Tue, 15 Nov 2005 09:58:52 +0000 (GMT)
> Robert Watson <rwatson@FreeBSD.org> wrote:
> > 
> > On Tue, 15 Nov 2005, Alexander Leidinger wrote:
> > 
> > >>  Modified files:
> > >>    sys/dev/sound/pcm    channel.c
> > >>  Log:
> > >>  Unbreak kernel builds.
> > >> 
> > >>  Submitted by:   arr
> > >
> > > Hos does the change from "min & (min-1) == 0" to "(min & (min-1))
> > > == 0"  fix the building of a kernel (what was the error message
> > > from gcc)?
> > 
> > Probably a combination of -Wall and -Werror, which generally
> > generates a  warning along the following lines:
> > 
> >      warning: suggest parentheses around comparison in operand of &
> > 
> That means, warnings caused by excessive inlining while compiling
> maestro.c should also break the build if WARNS=1, right? Has anybody
> encounter and getting annoyed by this?

No, function inlining doesn't change the semantics of expressions.

Stefan