From owner-freebsd-current@FreeBSD.ORG Mon Sep 29 11:39:43 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 43EB116A4C0 for ; Mon, 29 Sep 2003 11:39:43 -0700 (PDT) Received: from zibbi.icomtek.csir.co.za (zibbi.icomtek.csir.co.za [146.64.24.58]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0AC1F43FF9 for ; Mon, 29 Sep 2003 11:39:40 -0700 (PDT) (envelope-from jhay@zibbi.icomtek.csir.co.za) Received: from zibbi.icomtek.csir.co.za (localhost [IPv6:::1]) h8TIdPqs088759; Mon, 29 Sep 2003 20:39:25 +0200 (SAST) (envelope-from jhay@zibbi.icomtek.csir.co.za) Received: (from jhay@localhost) by zibbi.icomtek.csir.co.za (8.12.9/8.12.9/Submit) id h8TIdM7s088751; Mon, 29 Sep 2003 20:39:22 +0200 (SAST) (envelope-from jhay) Date: Mon, 29 Sep 2003 20:39:22 +0200 From: John Hay To: Maksim Yevmenkin Message-ID: <20030929183921.GA88439@zibbi.icomtek.csir.co.za> References: <20030923222402.54131.qmail@web40309.mail.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030923222402.54131.qmail@web40309.mail.yahoo.com> User-Agent: Mutt/1.4i cc: current@freebsd.org Subject: Re: Bluetooth patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Sep 2003 18:39:43 -0000 Hi Maksim, > I have prepared Bluetooth mega patch for FreeBSD source tree. This patch > updates FreeBSD sources to the most recent snapshot. The patch is quite > extensive - it adds two new libraries (libbluetooth and libsdp) as well > as puts some files into /etc/bluetooth and modifies quite a few other files. > I also have modified Makefile's to add new libraries and usr.{s}bin/bluetooth > to the build. > > I've sent it to Julian and Ruslan, but they do not have free time to look > at it. If anyone wants to review the patch please do so and let me know if > i missed/forget anything. > > The patch could be downloaded from > > http://www.geocities.com/m_evmenkin/patch/bluetooth20030914.diff.gz I had a look at the patch and here is my comments. I haven't tried it yet, but I did try your latest snapshot. I haven't looked at the man page markup, someone more knowledgable can do that, or it can be committed and then Ruslan can have a look at it when he gets time. There are lots of $FreeBSD$ changes. In a lot of the files that is the only change. The additions in lib/Makefile, share/man/man5/Makefile should be sorted alphabetically. I think libbluetooth and libsdp should be added to share/mk/bsd.libnames.mk and then the Makefiles should be modified to use ${LIBBLUETOOTH} and ${LIBSDP} on the DPADD lines. /usr/lib/libbluetooth.a should not be hardcoded otherwise buildworld won't work correctly. The + after DPADD and LDADD should be removed. It should only be used when a Makefile have more than one DPADD or LDADD line There should not be '-L/usr/lib' on the LDADD line. PS. Will Julian commit it when there was a review or are you looking for a committer too? John -- John Hay -- John.Hay@icomtek.csir.co.za / jhay@FreeBSD.org