From owner-cvs-src@FreeBSD.ORG Thu Jan 18 19:27:52 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7C06216A4A0; Thu, 18 Jan 2007 19:27:52 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.NUXI.org (trang.nuxi.org [66.93.134.19]) by mx1.freebsd.org (Postfix) with ESMTP id 1491F13C4C6; Thu, 18 Jan 2007 19:27:51 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.8/8.13.8) with ESMTP id l0IIuG9W067864; Thu, 18 Jan 2007 10:56:16 -0800 (PST) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.8/8.13.7/Submit) id l0IIuGaq067863; Thu, 18 Jan 2007 10:56:16 -0800 (PST) (envelope-from obrien) Date: Thu, 18 Jan 2007 10:56:16 -0800 From: "David O'Brien" To: Gleb Smirnoff Message-ID: <20070118185616.GA67767@dragon.NUXI.org> References: <200701181355.l0IDtMFu003540@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200701181355.l0IDtMFu003540@repoman.freebsd.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netgraph ng_ppp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2007 19:27:52 -0000 On Thu, Jan 18, 2007 at 01:55:21PM +0000, Gleb Smirnoff wrote: > glebius 2007-01-18 13:55:21 UTC > > FreeBSD src repository > > Modified files: > sys/netgraph ng_ppp.c > Log: > Revise the ng_ppp(4) node, so that code flow is more clear. All non-link > hooks get their per hook rcvdata methods, and all functions are organized > corresponding to protocol stack model. Hi glebius, This seems to have broken the kernel build: /usr/src/sys/modules/netgraph/ppp/../../../netgraph/ng_ppp.c: In function `ng_ppp_rcvdata': /usr/src/sys/modules/netgraph/ppp/../../../netgraph/ng_ppp.c:1287: warning: comparison is always true due to limited range of data type *** Error code 1 I commented out the KASSERT in order to get the kernel buildable again. Would you be able to take a look at the logic in the KASSERT? I'd rather not guess what you'd like there and possibly get it wrong. thanks, -- -- David (obrien@FreeBSD.org)